From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 18/39] drm/i915: Differentiate between ggtt->mutex and ppgtt->mutex Date: Thu, 03 Jan 2019 15:29:23 +0200 Message-ID: <87a7kh50p8.fsf@gaia.fi.intel.com> References: <20190102094139.24014-1-chris@chris-wilson.co.uk> <20190102094139.24014-18-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 236E96EB12 for ; Thu, 3 Jan 2019 13:31:00 +0000 (UTC) In-Reply-To: <20190102094139.24014-18-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gV2UgaGF2 ZSB0d28gY2xhc3NlcyBvZiBWTSwgZ2xvYmFsIEdUVCBhbmQgcGVyLXByb2Nlc3MgR1RULiBJbiBv cmRlciB0bwo+IGFsbG93IG91cnNlbHZlcyB0aGUgZnJlZWRvbSB0byBtaXggYm90aCBhbG9uZyBj YWxsIGNoYWlucywgZGlzdGluZ3Vpc2gKPiB0aGUgdHdvIGNsYXNzZXMgd2l0aCByZWdhcmRzIHRv IHRoZWlyIG11dGV4IGFuZCBsb2NrZGVwIG1hcHMuCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBX aWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW1fZ3R0LmMgICAgICAgfCAxMCArKysrKy0tLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5oICAgICAgIHwgIDIgKysKPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvc2VsZnRlc3RzL21vY2tfZ3R0LmMgfCAgNiArKystLS0KPiAgMyBmaWxlcyBjaGFuZ2Vk LCAxMCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW1fZ3R0LmMKPiBpbmRleCA4NTJkYmMxZjE4NWYuLjhmOTNiMWRmZmJiOSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gQEAgLTQ3NCw4ICs0NzQsNyBAQCBzdGF0aWMg dm9pZCB2bV9mcmVlX3BhZ2Uoc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sIHN0cnVjdCBw YWdlICpwYWdlKQo+ICAJc3Bpbl91bmxvY2soJnZtLT5mcmVlX3BhZ2VzLmxvY2spOwo+ICB9Cj4g IAo+IC1zdGF0aWMgdm9pZCBpOTE1X2FkZHJlc3Nfc3BhY2VfaW5pdChzdHJ1Y3QgaTkxNV9hZGRy ZXNzX3NwYWNlICp2bSwKPiAtCQkJCSAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYpCj4gK3N0YXRpYyB2b2lkIGk5MTVfYWRkcmVzc19zcGFjZV9pbml0KHN0cnVjdCBpOTE1X2Fk ZHJlc3Nfc3BhY2UgKnZtLCBpbnQgc3ViY2xhc3MpCj4gIHsKPiAgCS8qCj4gIAkgKiBUaGUgdm0t Pm11dGV4IG11c3QgYmUgcmVjbGFpbSBzYWZlIChmb3IgdXNlIGluIHRoZSBzaHJpbmtlcikuCj4g QEAgLTQ4Myw2ICs0ODIsNyBAQCBzdGF0aWMgdm9pZCBpOTE1X2FkZHJlc3Nfc3BhY2VfaW5pdChz dHJ1Y3QgaTkxNV9hZGRyZXNzX3NwYWNlICp2bSwKPiAgCSAqIGF0dGVtcHQgaG9sZGluZyB0aGUg bG9jayBpcyBpbW1lZGlhdGVseSByZXBvcnRlZCBieSBsb2NrZGVwLgo+ICAJICovCj4gIAltdXRl eF9pbml0KCZ2bS0+bXV0ZXgpOwo+ICsJbG9ja2RlcF9zZXRfc3ViY2xhc3MoJnZtLT5tdXRleCwg c3ViY2xhc3MpOwoKRmlyc3QgSSB3YXMgY29uZnVzZWQgYXMgdGhpcyBpcyBwZXIgaW5zdGFuY2Uu IEJ1dCB5ZWFoCmxvY2tkZXAgdHJhY2tzIGJ5IGNsYXNzLgoKPiAgCWk5MTVfZ2VtX3Nocmlua2Vy X3RhaW50c19tdXRleCgmdm0tPm11dGV4KTsKPiAgCj4gIAlHRU1fQlVHX09OKCF2bS0+dG90YWwp Owo+IEBAIC0xNTQ4LDcgKzE1NDgsNyBAQCBzdGF0aWMgc3RydWN0IGk5MTVfaHdfcHBndHQgKmdl bjhfcHBndHRfY3JlYXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ICAJLyogRnJv bSBiZHcsIHRoZXJlIGlzIHN1cHBvcnQgZm9yIHJlYWQtb25seSBwYWdlcyBpbiB0aGUgUFBHVFQu ICovCj4gIAlwcGd0dC0+dm0uaGFzX3JlYWRfb25seSA9IHRydWU7Cj4gIAo+IC0JaTkxNV9hZGRy ZXNzX3NwYWNlX2luaXQoJnBwZ3R0LT52bSwgaTkxNSk7Cj4gKwlpOTE1X2FkZHJlc3Nfc3BhY2Vf aW5pdCgmcHBndHQtPnZtLCBWTV9DTEFTU19QUEdUVCk7Cj4gIAo+ICAJLyogVGhlcmUgYXJlIG9u bHkgZmV3IGV4Y2VwdGlvbnMgZm9yIGdlbiA+PTYuIGNodiBhbmQgYnh0Lgo+ICAJICogQW5kIHdl IGFyZSBub3Qgc3VyZSBhYm91dCB0aGUgbGF0dGVyIHNvIHBsYXkgc2FmZSBmb3Igbm93Lgo+IEBA IC0xOTk3LDcgKzE5OTcsNyBAQCBzdGF0aWMgc3RydWN0IGk5MTVfaHdfcHBndHQgKmdlbjZfcHBn dHRfY3JlYXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ICAKPiAgCXBwZ3R0LT5i YXNlLnZtLnRvdGFsID0gSTkxNV9QREVTICogR0VONl9QVEVTICogSTkxNV9HVFRfUEFHRV9TSVpF Owo+ICAKPiAtCWk5MTVfYWRkcmVzc19zcGFjZV9pbml0KCZwcGd0dC0+YmFzZS52bSwgaTkxNSk7 Cj4gKwlpOTE1X2FkZHJlc3Nfc3BhY2VfaW5pdCgmcHBndHQtPmJhc2Uudm0sIFZNX0NMQVNTX1BQ R1RUKTsKPiAgCj4gIAlwcGd0dC0+YmFzZS52bS5hbGxvY2F0ZV92YV9yYW5nZSA9IGdlbjZfYWxs b2NfdmFfcmFuZ2U7Cj4gIAlwcGd0dC0+YmFzZS52bS5jbGVhcl9yYW5nZSA9IGdlbjZfcHBndHRf Y2xlYXJfcmFuZ2U7Cj4gQEAgLTM0MzQsNyArMzQzNCw3IEBAIGludCBpOTE1X2dndHRfaW5pdF9o dyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAkgKiBhbmQgYmV5b25kIHRo ZSBlbmQgb2YgdGhlIEdUVCBpZiB3ZSBkbyBub3QgcHJvdmlkZSBhIGd1YXJkLgo+ICAJICovCj4g IAltdXRleF9sb2NrKCZkZXZfcHJpdi0+ZHJtLnN0cnVjdF9tdXRleCk7Cj4gLQlpOTE1X2FkZHJl c3Nfc3BhY2VfaW5pdCgmZ2d0dC0+dm0sIGRldl9wcml2KTsKPiArCWk5MTVfYWRkcmVzc19zcGFj ZV9pbml0KCZnZ3R0LT52bSwgVk1fQ0xBU1NfR0dUVCk7Cj4gIAo+ICAJZ2d0dC0+dm0uaXNfZ2d0 dCA9IHRydWU7Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bV9ndHQuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5oCj4gaW5kZXggZTIz NjBmMTY0MjdhLi45MjI5YjAzZDYyOWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW1fZ3R0LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9n dHQuaAo+IEBAIC0yODgsNiArMjg4LDggQEAgc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSB7Cj4g IAlib29sIGNsb3NlZDsKPiAgCj4gIAlzdHJ1Y3QgbXV0ZXggbXV0ZXg7IC8qIHByb3RlY3RzIHZt YSBhbmQgb3VyIGxpc3RzICovCj4gKyNkZWZpbmUgVk1fQ0xBU1NfR0dUVCAwCj4gKyNkZWZpbmUg Vk1fQ0xBU1NfUFBHVFQgMQo+ICAKPiAgCXU2NCBzY3JhdGNoX3B0ZTsKPiAgCXN0cnVjdCBpOTE1 X3BhZ2VfZG1hIHNjcmF0Y2hfcGFnZTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvc2VsZnRlc3RzL21vY2tfZ3R0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMv bW9ja19ndHQuYwo+IGluZGV4IDZhZTQxOGM3NjAxNS4uOTc2Yzg2MmIzODQyIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX2d0dC5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL21vY2tfZ3R0LmMKPiBAQCAtNzAsNyArNzAsNyBA QCBtb2NrX3BwZ3R0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+ICAJcHBndHQtPnZt LnRvdGFsID0gcm91bmRfZG93bihVNjRfTUFYLCBQQUdFX1NJWkUpOwo+ICAJcHBndHQtPnZtLmZp bGUgPSBFUlJfUFRSKC1FTk9ERVYpOwo+ICAKPiAtCWk5MTVfYWRkcmVzc19zcGFjZV9pbml0KCZw cGd0dC0+dm0sIGk5MTUpOwo+ICsJaTkxNV9hZGRyZXNzX3NwYWNlX2luaXQoJnBwZ3R0LT52bSwg Vk1fQ0xBU1NfUFBHVFQpOwo+ICAKPiAgCXBwZ3R0LT52bS5jbGVhcl9yYW5nZSA9IG5vcF9jbGVh cl9yYW5nZTsKPiAgCXBwZ3R0LT52bS5pbnNlcnRfcGFnZSA9IG1vY2tfaW5zZXJ0X3BhZ2U7Cj4g QEAgLTEwMiw2ICsxMDIsNyBAQCB2b2lkIG1vY2tfaW5pdF9nZ3R0KHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICppOTE1KQo+ICAJc3RydWN0IGk5MTVfZ2d0dCAqZ2d0dCA9ICZpOTE1LT5nZ3R0Owo+ ICAKPiAgCWdndHQtPnZtLmk5MTUgPSBpOTE1Owo+ICsJZ2d0dC0+dm0uaXNfZ2d0dCA9IHRydWU7 CgpPbiB0aGUgbm9uIG1vY2tpbmcgc2lkZSB3ZSBzZXQgdGhpcyBhZnRlciB0aGUgYWRkcmVzcyBz cGFjZSBpbml0LApzbyB3cnQgdGhhdCBpdCBpcyBhc3ltbWV0cmljLgoKPiAgCj4gIAlnZ3R0LT5n bWFkciA9IChzdHJ1Y3QgcmVzb3VyY2UpIERFRklORV9SRVNfTUVNKDAsIDIwNDggKiBQQUdFX1NJ WkUpOwo+ICAJZ2d0dC0+bWFwcGFibGVfZW5kID0gcmVzb3VyY2Vfc2l6ZSgmZ2d0dC0+Z21hZHIp Owo+IEBAIC0xMTcsOSArMTE4LDggQEAgdm9pZCBtb2NrX2luaXRfZ2d0dChzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqaTkxNSkKPiAgCWdndHQtPnZtLnZtYV9vcHMuc2V0X3BhZ2VzICAgPSBnZ3R0 X3NldF9wYWdlczsKPiAgCWdndHQtPnZtLnZtYV9vcHMuY2xlYXJfcGFnZXMgPSBjbGVhcl9wYWdl czsKPiAgCj4gLQlpOTE1X2FkZHJlc3Nfc3BhY2VfaW5pdCgmZ2d0dC0+dm0sIGk5MTUpOwo+ICAK PiAtCWdndHQtPnZtLmlzX2dndHQgPSB0cnVlOwoKRXh0cmEgd2hpdGVzcGFjZSByZW1haW5zIGhl cmUuCgo+ICsJaTkxNV9hZGRyZXNzX3NwYWNlX2luaXQoJmdndHQtPnZtLCBWTV9DTEFTU19HR1RU KTsKCkFuZCBub3cgd2hlbiB5b3UgaGF2ZSB0aGUgc3ViY2xhc3MsIHlvdSBjb3VsZAplbWJyYWNl IGl0IGZ1bGx5IGFuZCBzZXQgdGhlIGlzX2dndHQgYmFzZWQgb24gaXQsCmluc2lkZSBpOTE1X2Fk ZHJlc3Nfc3BhY2VfaW5pdC4KCi1NaWthCgo+ICB9Cj4gIAo+ICB2b2lkIG1vY2tfZmluaV9nZ3R0 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+IC0tIAo+IDIuMjAuMQpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK