From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39755)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1ft8iS-0003be-EN
	for qemu-devel@nongnu.org; Fri, 24 Aug 2018 05:49:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1ft8iN-0005oS-F0
	for qemu-devel@nongnu.org; Fri, 24 Aug 2018 05:49:16 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <20180823165410.5ff77164.cohuck@redhat.com> (Cornelia Huck's
	message of "Thu, 23 Aug 2018 16:54:10 +0200")
References: <1535027120-26187-1-git-send-email-thuth@redhat.com>
	<20180823165410.5ff77164.cohuck@redhat.com>
Reply-To: quintela@redhat.com
Date: Fri, 24 Aug 2018 11:49:01 +0200
Message-ID: <87a7pcqelu.fsf@trasno.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] tests/migration: Enable the migration test
 on s390x, too
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, qemu-devel@nongnu.org, qemu-s390x@nongnu.org

Cornelia Huck <cohuck@redhat.com> wrote:
> On Thu, 23 Aug 2018 14:25:20 +0200
> Thomas Huth <thuth@redhat.com> wrote:
>
>> We can re-use the s390-ccw bios code to implement a small firmware
>> for a s390x guest which prints out the "A" and "B" characters and
>> modifies the memory, as required for the migration test.
>> 
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  tests/Makefile.include               |   1 +
>>  tests/migration-test.c               |  23 ++
>>  tests/migration/s390x-a-b-rebuild.sh |  42 ++++
>>  tests/migration/s390x-a-b.c          |  35 +++
>>  tests/migration/s390x-a-b.h          | 427 +++++++++++++++++++++++++++++++++++
>>  5 files changed, 528 insertions(+)
>>  create mode 100755 tests/migration/s390x-a-b-rebuild.sh
>>  create mode 100644 tests/migration/s390x-a-b.c
>>  create mode 100644 tests/migration/s390x-a-b.h
>
> Hm, I wanted to comment that those new files should be added to the
> MAINTAINERS file pattern (here as well :), but tests/migration does not
> seem to have an entry in MAINTAINERS yet...
>
>
>> diff --git a/tests/migration/s390x-a-b.h b/tests/migration/s390x-a-b.h
>> new file mode 100644
>> index 0000000..eb1bab4
>> --- /dev/null
>> +++ b/tests/migration/s390x-a-b.h
>> @@ -0,0 +1,427 @@
>> +/*
>> + * This file is automatically generated from tests/migration/s390x-a-b.c, edit
>> + * that and then run tests/migration/s390x-a-b-rebuild.sh to update, and then
>> + * remember to send both in your patch submission.
>> + */
>
> And here I assumed that this file would be lovingly hand-crafted :)
>
> Looks sane to me:
>
> Acked-by: Cornelia Huck <cohuck@redhat.com>
>
> Juan, from your previous mails I gather that you'll take this through
> your tree, right?

Yeap.  Thanks.