From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fpdWG-0006i2-Cs for qemu-devel@nongnu.org; Tue, 14 Aug 2018 13:54:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fpdW1-0004Dd-Cl for qemu-devel@nongnu.org; Tue, 14 Aug 2018 13:54:12 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:37010 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fpdW1-0004DA-6S for qemu-devel@nongnu.org; Tue, 14 Aug 2018 13:53:57 -0400 From: Markus Armbruster References: <1534258018-22859-1-git-send-email-thuth@redhat.com> <1534258018-22859-3-git-send-email-thuth@redhat.com> Date: Tue, 14 Aug 2018 19:53:53 +0200 In-Reply-To: <1534258018-22859-3-git-send-email-thuth@redhat.com> (Thomas Huth's message of "Tue, 14 Aug 2018 16:46:54 +0200") Message-ID: <87a7pou95a.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/6] tests/device-introspection: Check that the qom-tree and qtree do not change List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Juan Quintela , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , "Dr. David Alan Gilbert" , Paolo Bonzini Thomas Huth writes: > Introspection should not change the qom-tree / qtree, so we should check > this in the device-introspect-test, too. This patch helped to find lots > of instrospection bugs during the QEMU v3.0 soft/hard-freeze period in the > last two months. Clever idea. > Signed-off-by: Thomas Huth > --- > tests/device-introspect-test.c | 23 +++++++++++++++++++---- > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/tests/device-introspect-test.c b/tests/device-introspect-test.c > index 0b4f221..5b7ec05 100644 > --- a/tests/device-introspect-test.c > +++ b/tests/device-introspect-test.c > @@ -103,7 +103,14 @@ static QList *device_type_list(bool abstract) > static void test_one_device(const char *type) > { > QDict *resp; > - char *help, *qom_tree; > + char *help; > + char *qom_tree_start, *qom_tree_end; > + char *qtree_start, *qtree_end; > + > + g_debug("Testing device '%s'", type); This is only the second use of g_debug() in tests/. What are you trying to accomplish? > + > + qom_tree_start = hmp("info qom-tree"); > + qtree_start = hmp("info qtree"); > > resp = qmp("{'execute': 'device-list-properties'," > " 'arguments': {'typename': %s}}", > @@ -115,10 +122,18 @@ static void test_one_device(const char *type) > > /* > * Some devices leave dangling pointers in QOM behind. > - * "info qom-tree" has a good chance at crashing then > + * "info qom-tree" or "info qtree" have a good chance at crashing then. > + * Also make sure that the tree did not change. > */ > - qom_tree = hmp("info qom-tree"); > - g_free(qom_tree); > + qom_tree_end = hmp("info qom-tree"); > + g_assert_cmpstr(qom_tree_start, ==, qom_tree_end); > + g_free(qom_tree_start); > + g_free(qom_tree_end); > + > + qtree_end = hmp("info qtree"); > + g_assert_cmpstr(qtree_start, ==, qtree_end); > + g_free(qtree_start); > + g_free(qtree_end); > } > > static void test_device_intro_list(void) Output of "info qom-tree" depends on hash table iteration order, but that could almost be considered a feature here.