From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Tue, 03 Jul 2018 11:57:08 +0000 Subject: Re: [PATCH] video/console/vgacon: Print big fat warning with nomodeset Message-Id: <87a7r8r0q3.fsf@intel.com> List-Id: References: <20180702210442.18648-1-lyude@redhat.com> <20180703073452.GD7880@phenom.ffwll.local> In-Reply-To: <20180703073452.GD7880@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Vetter , Lyude Paul Cc: linux-fbdev@vger.kernel.org, Kees Cook , Bartlomiej Zolnierkiewicz , =?utf-8?Q?Jan_H=2E?= =?utf-8?Q?_Sch=C3=B6nherr?= , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bjorn Helgaas On Tue, 03 Jul 2018, Daniel Vetter wrote: > On Mon, Jul 02, 2018 at 05:04:40PM -0400, Lyude Paul wrote: >> It's been a pretty good while since kernel modesetting was introduced. >> It has almost entirely replaced previous solutions which required >> userspace modesetting, and I can't even recall any drivers off the top >> of my head for modern day hardware that don't only support one or the >> other. Even nvidia's ugly blob does not require the use of nomodeset, >> and only requires that nouveau be blacklisted. >> >> Effectively, the only thing nomodeset does in the year 2018 is disable >> your graphics drivers. Since VESA is a thing, this will give many users >> the false impression that they've actually fixed an issue they were >> having with their machine simply because the laptop will boot up to a >> degraded GUI. This of course, is never actually the case. >> >> Things get even worse when you consider that there's still an enormous >> amount of tutorials users find on the internet that still suggest adding >> nomodeset, along with various users who have been around long enough to >> still suggest it. >> >> There really isn't any legitimate reason I can see for this to be an >> option that's used by anyone else other then developers, or properly >> informed users. So, let's end the confusion and start printing warnings >> whenever it's enabled. >> >> Signed-off-by: Lyude Paul > > Yeah makes tons of sense. I think we should also perhaps mark the option > as a tainting one, but I think that's only wired up for module option. You could do that by adding add_taint(TAINT_USER, LOCKDEP_STILL_OK); in text_mode(). If you do that, you should probably amend the warning message accordingly. Either way, Acked-by: Jani Nikula > Reviewed-by: Daniel Vetter > >> --- >> drivers/video/console/vgacon.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c >> index f09e17b60e45..09731b2f6815 100644 >> --- a/drivers/video/console/vgacon.c >> +++ b/drivers/video/console/vgacon.c >> @@ -112,6 +112,11 @@ EXPORT_SYMBOL(vgacon_text_force); >> static int __init text_mode(char *str) >> { >> vgacon_text_mode_force = true; >> + >> + pr_warning("You have booted with nomodeset. This means your GPU drivers are DISABLED\n"); >> + pr_warning("Any video related functionality will be severely degraded, and you may not even be able to suspend the system properly\n"); >> + pr_warning("Unless you actually understand what nomodeset does, you should reboot without enabling it\n"); >> + >> return 1; >> } >> >> -- >> 2.17.1 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] video/console/vgacon: Print big fat warning with nomodeset Date: Tue, 03 Jul 2018 14:57:08 +0300 Message-ID: <87a7r8r0q3.fsf@intel.com> References: <20180702210442.18648-1-lyude@redhat.com> <20180703073452.GD7880@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9186F6E11A for ; Tue, 3 Jul 2018 11:57:39 +0000 (UTC) In-Reply-To: <20180703073452.GD7880@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Lyude Paul Cc: linux-fbdev@vger.kernel.org, Kees Cook , Bartlomiej Zolnierkiewicz , =?utf-8?Q?Jan_H=2E?= =?utf-8?Q?_Sch=C3=B6nherr?= , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bjorn Helgaas List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAwMyBKdWwgMjAxOCwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBNb24sIEp1bCAwMiwgMjAxOCBhdCAwNTowNDo0MFBNIC0wNDAwLCBMeXVkZSBQYXVs IHdyb3RlOgo+PiBJdCdzIGJlZW4gYSBwcmV0dHkgZ29vZCB3aGlsZSBzaW5jZSBrZXJuZWwgbW9k ZXNldHRpbmcgd2FzIGludHJvZHVjZWQuCj4+IEl0IGhhcyBhbG1vc3QgZW50aXJlbHkgcmVwbGFj ZWQgcHJldmlvdXMgc29sdXRpb25zIHdoaWNoIHJlcXVpcmVkCj4+IHVzZXJzcGFjZSBtb2Rlc2V0 dGluZywgYW5kIEkgY2FuJ3QgZXZlbiByZWNhbGwgYW55IGRyaXZlcnMgb2ZmIHRoZSB0b3AKPj4g b2YgbXkgaGVhZCBmb3IgbW9kZXJuIGRheSBoYXJkd2FyZSB0aGF0IGRvbid0IG9ubHkgc3VwcG9y dCBvbmUgb3IgdGhlCj4+IG90aGVyLiBFdmVuIG52aWRpYSdzIHVnbHkgYmxvYiBkb2VzIG5vdCBy ZXF1aXJlIHRoZSB1c2Ugb2Ygbm9tb2Rlc2V0LAo+PiBhbmQgb25seSByZXF1aXJlcyB0aGF0IG5v dXZlYXUgYmUgYmxhY2tsaXN0ZWQuCj4+IAo+PiBFZmZlY3RpdmVseSwgdGhlIG9ubHkgdGhpbmcg bm9tb2Rlc2V0IGRvZXMgaW4gdGhlIHllYXIgMjAxOCBpcyBkaXNhYmxlCj4+IHlvdXIgZ3JhcGhp Y3MgZHJpdmVycy4gU2luY2UgVkVTQSBpcyBhIHRoaW5nLCB0aGlzIHdpbGwgZ2l2ZSBtYW55IHVz ZXJzCj4+IHRoZSBmYWxzZSBpbXByZXNzaW9uIHRoYXQgdGhleSd2ZSBhY3R1YWxseSBmaXhlZCBh biBpc3N1ZSB0aGV5IHdlcmUKPj4gaGF2aW5nIHdpdGggdGhlaXIgbWFjaGluZSBzaW1wbHkgYmVj YXVzZSB0aGUgbGFwdG9wIHdpbGwgYm9vdCB1cCB0byBhCj4+IGRlZ3JhZGVkIEdVSS4gVGhpcyBv ZiBjb3Vyc2UsIGlzIG5ldmVyIGFjdHVhbGx5IHRoZSBjYXNlLgo+PiAKPj4gVGhpbmdzIGdldCBl dmVuIHdvcnNlIHdoZW4geW91IGNvbnNpZGVyIHRoYXQgdGhlcmUncyBzdGlsbCBhbiBlbm9ybW91 cwo+PiBhbW91bnQgb2YgdHV0b3JpYWxzIHVzZXJzIGZpbmQgb24gdGhlIGludGVybmV0IHRoYXQg c3RpbGwgc3VnZ2VzdCBhZGRpbmcKPj4gbm9tb2Rlc2V0LCBhbG9uZyB3aXRoIHZhcmlvdXMgdXNl cnMgd2hvIGhhdmUgYmVlbiBhcm91bmQgbG9uZyBlbm91Z2ggdG8KPj4gc3RpbGwgc3VnZ2VzdCBp dC4KPj4gCj4+IFRoZXJlIHJlYWxseSBpc24ndCBhbnkgbGVnaXRpbWF0ZSByZWFzb24gSSBjYW4g c2VlIGZvciB0aGlzIHRvIGJlIGFuCj4+IG9wdGlvbiB0aGF0J3MgdXNlZCBieSBhbnlvbmUgZWxz ZSBvdGhlciB0aGVuIGRldmVsb3BlcnMsIG9yIHByb3Blcmx5Cj4+IGluZm9ybWVkIHVzZXJzLiBT bywgbGV0J3MgZW5kIHRoZSBjb25mdXNpb24gYW5kIHN0YXJ0IHByaW50aW5nIHdhcm5pbmdzCj4+ IHdoZW5ldmVyIGl0J3MgZW5hYmxlZC4KPj4gCj4+IFNpZ25lZC1vZmYtYnk6IEx5dWRlIFBhdWwg PGx5dWRlQHJlZGhhdC5jb20+Cj4KPiBZZWFoIG1ha2VzIHRvbnMgb2Ygc2Vuc2UuIEkgdGhpbmsg d2Ugc2hvdWxkIGFsc28gcGVyaGFwcyBtYXJrIHRoZSBvcHRpb24KPiBhcyBhIHRhaW50aW5nIG9u ZSwgYnV0IEkgdGhpbmsgdGhhdCdzIG9ubHkgd2lyZWQgdXAgZm9yIG1vZHVsZSBvcHRpb24uCgpZ b3UgY291bGQgZG8gdGhhdCBieSBhZGRpbmcKCglhZGRfdGFpbnQoVEFJTlRfVVNFUiwgTE9DS0RF UF9TVElMTF9PSyk7CgppbiB0ZXh0X21vZGUoKS4gSWYgeW91IGRvIHRoYXQsIHlvdSBzaG91bGQg cHJvYmFibHkgYW1lbmQgdGhlIHdhcm5pbmcKbWVzc2FnZSBhY2NvcmRpbmdseS4KCkVpdGhlciB3 YXksCgpBY2tlZC1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KCj4gUmV2 aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4KPj4gLS0t Cj4+ICBkcml2ZXJzL3ZpZGVvL2NvbnNvbGUvdmdhY29uLmMgfCA1ICsrKysrCj4+ICAxIGZpbGUg Y2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCj4+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRl by9jb25zb2xlL3ZnYWNvbi5jIGIvZHJpdmVycy92aWRlby9jb25zb2xlL3ZnYWNvbi5jCj4+IGlu ZGV4IGYwOWUxN2I2MGU0NS4uMDk3MzFiMmY2ODE1IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL3Zp ZGVvL2NvbnNvbGUvdmdhY29uLmMKPj4gKysrIGIvZHJpdmVycy92aWRlby9jb25zb2xlL3ZnYWNv bi5jCj4+IEBAIC0xMTIsNiArMTEyLDExIEBAIEVYUE9SVF9TWU1CT0wodmdhY29uX3RleHRfZm9y Y2UpOwo+PiAgc3RhdGljIGludCBfX2luaXQgdGV4dF9tb2RlKGNoYXIgKnN0cikKPj4gIHsKPj4g IAl2Z2Fjb25fdGV4dF9tb2RlX2ZvcmNlID0gdHJ1ZTsKPj4gKwo+PiArCXByX3dhcm5pbmcoIllv dSBoYXZlIGJvb3RlZCB3aXRoIG5vbW9kZXNldC4gVGhpcyBtZWFucyB5b3VyIEdQVSBkcml2ZXJz IGFyZSBESVNBQkxFRFxuIik7Cj4+ICsJcHJfd2FybmluZygiQW55IHZpZGVvIHJlbGF0ZWQgZnVu Y3Rpb25hbGl0eSB3aWxsIGJlIHNldmVyZWx5IGRlZ3JhZGVkLCBhbmQgeW91IG1heSBub3QgZXZl biBiZSBhYmxlIHRvIHN1c3BlbmQgdGhlIHN5c3RlbSBwcm9wZXJseVxuIik7Cj4+ICsJcHJfd2Fy bmluZygiVW5sZXNzIHlvdSBhY3R1YWxseSB1bmRlcnN0YW5kIHdoYXQgbm9tb2Rlc2V0IGRvZXMs IHlvdSBzaG91bGQgcmVib290IHdpdGhvdXQgZW5hYmxpbmcgaXRcbiIpOwo+PiArCj4+ICAJcmV0 dXJuIDE7Cj4+ICB9Cj4+ICAKPj4gLS0gCj4+IDIuMTcuMQo+PiAKPj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPj4gZHJpLWRldmVsIG1haWxpbmcgbGlz dAo+PiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKSmFuaSBOaWt1bGEs IEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 957CCC6778A for ; Tue, 3 Jul 2018 11:57:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 491F524C8F for ; Tue, 3 Jul 2018 11:57:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 491F524C8F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752721AbeGCL5l (ORCPT ); Tue, 3 Jul 2018 07:57:41 -0400 Received: from mga09.intel.com ([134.134.136.24]:54424 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752067AbeGCL5k (ORCPT ); Tue, 3 Jul 2018 07:57:40 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2018 04:57:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,303,1526367600"; d="scan'208";a="69275097" Received: from jnikula-mobl2.fi.intel.com (HELO localhost) ([10.237.72.62]) by fmsmga001.fm.intel.com with ESMTP; 03 Jul 2018 04:57:23 -0700 From: Jani Nikula To: Daniel Vetter , Lyude Paul Cc: linux-fbdev@vger.kernel.org, Kees Cook , Bartlomiej Zolnierkiewicz , =?utf-8?Q?Jan_H=2E?= =?utf-8?Q?_Sch=C3=B6nherr?= , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bjorn Helgaas Subject: Re: [PATCH] video/console/vgacon: Print big fat warning with nomodeset In-Reply-To: <20180703073452.GD7880@phenom.ffwll.local> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20180702210442.18648-1-lyude@redhat.com> <20180703073452.GD7880@phenom.ffwll.local> Date: Tue, 03 Jul 2018 14:57:08 +0300 Message-ID: <87a7r8r0q3.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 03 Jul 2018, Daniel Vetter wrote: > On Mon, Jul 02, 2018 at 05:04:40PM -0400, Lyude Paul wrote: >> It's been a pretty good while since kernel modesetting was introduced. >> It has almost entirely replaced previous solutions which required >> userspace modesetting, and I can't even recall any drivers off the top >> of my head for modern day hardware that don't only support one or the >> other. Even nvidia's ugly blob does not require the use of nomodeset, >> and only requires that nouveau be blacklisted. >> >> Effectively, the only thing nomodeset does in the year 2018 is disable >> your graphics drivers. Since VESA is a thing, this will give many users >> the false impression that they've actually fixed an issue they were >> having with their machine simply because the laptop will boot up to a >> degraded GUI. This of course, is never actually the case. >> >> Things get even worse when you consider that there's still an enormous >> amount of tutorials users find on the internet that still suggest adding >> nomodeset, along with various users who have been around long enough to >> still suggest it. >> >> There really isn't any legitimate reason I can see for this to be an >> option that's used by anyone else other then developers, or properly >> informed users. So, let's end the confusion and start printing warnings >> whenever it's enabled. >> >> Signed-off-by: Lyude Paul > > Yeah makes tons of sense. I think we should also perhaps mark the option > as a tainting one, but I think that's only wired up for module option. You could do that by adding add_taint(TAINT_USER, LOCKDEP_STILL_OK); in text_mode(). If you do that, you should probably amend the warning message accordingly. Either way, Acked-by: Jani Nikula > Reviewed-by: Daniel Vetter > >> --- >> drivers/video/console/vgacon.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c >> index f09e17b60e45..09731b2f6815 100644 >> --- a/drivers/video/console/vgacon.c >> +++ b/drivers/video/console/vgacon.c >> @@ -112,6 +112,11 @@ EXPORT_SYMBOL(vgacon_text_force); >> static int __init text_mode(char *str) >> { >> vgacon_text_mode_force = true; >> + >> + pr_warning("You have booted with nomodeset. This means your GPU drivers are DISABLED\n"); >> + pr_warning("Any video related functionality will be severely degraded, and you may not even be able to suspend the system properly\n"); >> + pr_warning("Unless you actually understand what nomodeset does, you should reboot without enabling it\n"); >> + >> return 1; >> } >> >> -- >> 2.17.1 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Graphics Center