From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] gpu: Consistently use octal not symbolic permissions Date: Fri, 25 May 2018 09:41:22 +0300 Message-ID: <87a7so44q5.fsf@intel.com> References: <9b0f5f5cf6bccc003beef82f0972be655613075d.1527193246.git.joe@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <9b0f5f5cf6bccc003beef82f0972be655613075d.1527193246.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Joe Perches , Russell King , Gustavo Padovan , Maarten Lankhorst , Sean Paul , David Airlie , Zhenyu Wang , Zhi Wang , Joonas Lahtinen , Rodrigo Vivi , Rob Clark , Ben Skeggs , Alex Deucher , Christian =?utf-8?Q?K=C3=B6nig?= , "David (ChunMing) Zhou" , Benjamin Gaignard , Vincent Abriou , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Roger He , Dave Airlie , Thierry Reding Cc: freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Tomi Valkeinen , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, intel-gvt-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gVGh1LCAyNCBNYXkgMjAxOCwgSm9lIFBlcmNoZXMgPGpvZUBwZXJjaGVzLmNvbT4gd3JvdGU6 Cj4gVGhlcmUgaXMgY3VycmVudGx5IGEgbWl4dHVyZSBvZiBvY3RhbCBhbmQgc3ltYm9saWMgcGVy bWlzc2lvbnMgdXNlcwo+IGluIGZpbGVzIGluIGRyaXZlcnMvZ3B1L2RybSBhbmQgb25lIGZpbGUg aW4gZHJpdmVycy9ncHUuCj4KPiBUaGVyZSBhcmUgfjI3MCBleGlzdGluZyBvY3RhbCB1c2VzIGFu ZCB+MTE1IFNfPEZPTz4gdXNlcy4KPgo+IENvbnZlcnQgYWxsIHRoZSBTXzxGT08+IHN5bWJvbGlj IHBlcm1pc3Npb25zIHRvIHRoZWlyIG9jdGFsIGVxdWl2YWxlbnRzCj4gYXMgdXNpbmcgb2N0YWwg YW5kIG5vdCBzeW1ib2xpYyBwZXJtaXNzaW9ucyBpcyBwcmVmZXJyZWQgYnkgbWFueSBhcyBtb3Jl Cj4gcmVhZGFibGUuCj4KPiBzZWU6IGh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDE2LzgvMi8xOTQ1 Cj4KPiBEb25lIHdpdGggYXV0b21hdGVkIGNvbnZlcnNpb24gdmlhOgo+ICQgLi9zY3JpcHRzL2No ZWNrcGF0Y2gucGwgLWYgLS10eXBlcz1TWU1CT0xJQ19QRVJNUyAtLWZpeC1pbnBsYWNlIDxmaWxl cy4uLj4KPgo+IE1pc2NlbGxhbmVhOgo+Cj4gbyBXcmFwcGVkIG1vZGlmaWVkIG11bHRpLWxpbmUg Y2FsbHMgdG8gYSBzaW5nbGUgbGluZSB3aGVyZSBhcHByb3ByaWF0ZQo+IG8gUmVhbGlnbiBtb2Rp ZmllZCBtdWx0aS1saW5lIGNhbGxzIHRvIG9wZW4gcGFyZW50aGVzaXMKPiBvIGRyaXZlcnMvZ3B1 L2RybS9tc20vYWRyZW5vL2E1eHhfZGVidWdmcy5jIGhhcyBhIHdvcmxkLXdyaXRlYWJsZQo+ICAg ZGVidWcgcGVybWlzc2lvbiBmb3IgInJlc2V0IiAtIHBlcmhhcHMgdGhhdCBzaG91bGQgYmUgbW9k aWZpZWQKPgo+IFNpZ25lZC1vZmYtYnk6IEpvZSBQZXJjaGVzIDxqb2VAcGVyY2hlcy5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZWJ1Z2ZzLmMgICAgICAg IHwgIDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3BtLmMgICAgICAg ICAgICAgfCA5OCArKysrKysrKysrKy0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV9yaW5nLmMgICAgICAgICAgIHwgIDMgKy0KPiAgZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jICAgICAgICAgICAgfCAgOSArLQo+ICBkcml2ZXJzL2dw dS9kcm0vYXJtYWRhL2FybWFkYV9kZWJ1Z2ZzLmMgICAgICAgICAgICB8ICA0ICstCj4gIGRyaXZl cnMvZ3B1L2RybS9kcm1fZGVidWdmcy5jICAgICAgICAgICAgICAgICAgICAgIHwgIDYgKy0KPiAg ZHJpdmVycy9ncHUvZHJtL2RybV9kZWJ1Z2ZzX2NyYy5jICAgICAgICAgICAgICAgICAgfCAgNCAr LQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX3N5c2ZzLmMgICAgICAgICAgICAgICAgICAgICAgICB8 ICAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9maXJtd2FyZS5jICAgICAgICAgICAg ICAgIHwgIDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgICAgICAg ICAgICAgICAgfCAgOCArLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BlcmYuYyAgICAg ICAgICAgICAgICAgICB8ICAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc3lzZnMu YyAgICAgICAgICAgICAgICAgIHwgMjIgKystLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcGlwZV9jcmMuYyAgICAgICAgICAgICAgfCAgMiArLQoKUGxlYXNlIHNlbmQgYXQgbGVhc3Qg aTkxNSBjaGFuZ2VzIHNlcGFyYXRlbHkuIFRoZXJlJ3MgemVybyByZWFzb24gdG8KbWFrZSBvdXIg bGl2ZXMgaGFyZGVyIGZvciB0aGlzIGNoYW5nZS4KCkJSLApKYW5pLgoKLS0gCkphbmkgTmlrdWxh LCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9hbWQtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935268AbeEYGlg (ORCPT ); Fri, 25 May 2018 02:41:36 -0400 Received: from mga11.intel.com ([192.55.52.93]:59838 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751791AbeEYGle (ORCPT ); Fri, 25 May 2018 02:41:34 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,439,1520924400"; d="scan'208";a="58387185" From: Jani Nikula To: Joe Perches , Russell King , Gustavo Padovan , Maarten Lankhorst , Sean Paul , David Airlie , Zhenyu Wang , Zhi Wang , Joonas Lahtinen , Rodrigo Vivi , Rob Clark , Ben Skeggs , Alex Deucher , Christian =?utf-8?Q?K=C3=B6nig?= , "David \(ChunMing\) Zhou" , Benjamin Gaignard , Vincent Abriou , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Roger He , Dave Airlie , Thierry Reding Cc: Tomi Valkeinen , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] gpu: Consistently use octal not symbolic permissions In-Reply-To: <9b0f5f5cf6bccc003beef82f0972be655613075d.1527193246.git.joe@perches.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <9b0f5f5cf6bccc003beef82f0972be655613075d.1527193246.git.joe@perches.com> Date: Fri, 25 May 2018 09:41:22 +0300 Message-ID: <87a7so44q5.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 May 2018, Joe Perches wrote: > There is currently a mixture of octal and symbolic permissions uses > in files in drivers/gpu/drm and one file in drivers/gpu. > > There are ~270 existing octal uses and ~115 S_ uses. > > Convert all the S_ symbolic permissions to their octal equivalents > as using octal and not symbolic permissions is preferred by many as more > readable. > > see: https://lkml.org/lkml/2016/8/2/1945 > > Done with automated conversion via: > $ ./scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace > > Miscellanea: > > o Wrapped modified multi-line calls to a single line where appropriate > o Realign modified multi-line calls to open parenthesis > o drivers/gpu/drm/msm/adreno/a5xx_debugfs.c has a world-writeable > debug permission for "reset" - perhaps that should be modified > > Signed-off-by: Joe Perches > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 98 +++++++++++----------- > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 3 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 9 +- > drivers/gpu/drm/armada/armada_debugfs.c | 4 +- > drivers/gpu/drm/drm_debugfs.c | 6 +- > drivers/gpu/drm/drm_debugfs_crc.c | 4 +- > drivers/gpu/drm/drm_sysfs.c | 2 +- > drivers/gpu/drm/i915/gvt/firmware.c | 2 +- > drivers/gpu/drm/i915/i915_debugfs.c | 8 +- > drivers/gpu/drm/i915/i915_perf.c | 2 +- > drivers/gpu/drm/i915/i915_sysfs.c | 22 ++--- > drivers/gpu/drm/i915/intel_pipe_crc.c | 2 +- Please send at least i915 changes separately. There's zero reason to make our lives harder for this change. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center