From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from [2001:470:dc45:1000::1] (helo=mail.toke.dk) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eKneA-0005pI-Ex for ath10k@lists.infradead.org; Fri, 01 Dec 2017 15:54:41 +0000 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4 In-Reply-To: <1512143142.25588.17.camel@sipsolutions.net> References: <1512046701-14435-1-git-send-email-akolli@qti.qualcomm.com> <1512046701-14435-3-git-send-email-akolli@qti.qualcomm.com> <87k1y7zqtj.fsf@kamboji.qca.qualcomm.com> <87bmjjzppd.fsf@kamboji.qca.qualcomm.com> <5080a68538fd2d883e15bacaa969661b@codeaurora.org> <87r2se36rq.fsf@toke.dk> <87k1y6y04i.fsf@kamboji.qca.qualcomm.com> <87d13y31r0.fsf@toke.dk> <1512143142.25588.17.camel@sipsolutions.net> Date: Fri, 01 Dec 2017 16:54:12 +0100 Message-ID: <87a7z230m3.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg , Kalle Valo Cc: "linux-wireless-owner@vger.kernel.org" , Anilkumar Kolli , "akolli@codeaurora.org" , "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" Sm9oYW5uZXMgQmVyZyA8am9oYW5uZXNAc2lwc29sdXRpb25zLm5ldD4gd3JpdGVzOgoKPiBPbiBG cmksIDIwMTctMTItMDEgYXQgMTY6MjkgKzAxMDAsIFRva2UgSMO4aWxhbmQtSsO4cmdlbnNlbiB3 cm90ZToKPj4gCj4+IFllYWgsIGZpZ3VyZXMuIFdlbGwsIG1heWJlIHdlJ2xsIGp1c3QgaGF2ZSB0 byBzdXBwb3J0IGFuIGFzeW5jaHJvbm91cwo+PiBjYWxsYmFjayBpbnRvIG1hYzgwMjExIHRvIHJl Z2lzdGVyIGFpcnRpbWUgdXNhZ2UuIFdpbGwgcHJvYmFibHkgaGF2ZSB0bwo+PiBhZGQgc29tZSBh c3luY2hyb25pY2l0eSBhbnl3YXkgdG8gYXZvaWQgZG9pbmcgdG9vIG11Y2ggd29yayBpbiB0aGUg ZmFzdAo+PiBwYXRoLgo+Cj4gSSByZWFsbHkgdGhpbmsgd2Ugc2hvdWxkIGhhdmUgdGhhdCBhbnl3 YXkuIEluIGZhY3QsIHBlcmhhcHMgd2Ugc2hvdWxkCj4ganVzdCBlbmZvcmNlIGl0IHRoYXQgd2F5 PyBUaGVuIGF0aDlrIHdvdWxkIGhhdmUgdG8gZG8gYSBiaXQgbW9yZSB3b3JrLAo+IGJ1dCBpdCdz IGFsc28gdGhlIHNsb3dlciBvZiB0aGUgZGV2aWNlcyA6LSkKPgo+IEJ1dCB0aGlzIHBsYXlzIGlu IHdpdGggdGhlIHdob2xlIG11bHRpLXF1ZXVlIFJYIHdlIGRpc2N1c3NlZCBiZWZvcmUuCgpZZWFo LCB0aGF0J3Mgd2hhdCBJIG1lYW50IGJ5ICdhZGQgc29tZSBhc3luY2hyb25pY2l0eSBhbnl3YXkn IDopCgpJIGd1ZXNzIHRoYXQgb25jZSB3ZSBoYXZlIGFuIGFzeW5jaHJvbm91cyBzY2hlZHVsZXIg dGFzayBvZiBzb21lIGtpbmQsCnN1cHBvcnRpbmcgdGhlIGNhbGxiYWNrIGlzIGVhc3ksIGJ1dCBw dWxsaW5nIHRoZSBkYXRhIG91dCBvZiBlYWNoIHBhY2tldApuZWVkcyBtb3JlIHdvcmsuIEJ1dCBz aW5jZSB3ZSdsbCBoYXZlIHRvIGRvIHRoYXQgZm9yIGF0aDlrIGFueXdheSBpdApiZWNvbWVzIG1v cmUgYSBxdWVzdGlvbiBvZiB3aGV0aGVyIGl0J3Mgc29tZXRoaW5nIHRoYXQgc2hvdWxkIGJlCnN1 cHBvcnRlZCBpbiBtYWM4MDIxMSBvciBpZiBpdCBzaG91bGQgYmUgaW1wbGVtZW50ZWQgaW4gZWFj aCBkcml2ZXIuCkJ1dCBzaW5jZSB0aGF0IGxvZ2ljIHdpbGwgaGF2ZSB0byBiZSB3cml0dGVuIGZy b20gc2NyYXRjaCBhbnl3YXksIGlzCnRoZXJlIGFueSByZWFzb24gdG8gbm90IGp1c3QgZG8gaXQg aW4gbWFjODAyMTEgZnJvbSB0aGUgYmVnaW5uaW5nPwoKLVRva2UKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBr QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.toke.dk ([52.28.52.200]:50557 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752035AbdLAPyR (ORCPT ); Fri, 1 Dec 2017 10:54:17 -0500 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg , Kalle Valo Cc: "akolli\@codeaurora.org" , "ath10k\@lists.infradead.org" , "linux-wireless\@vger.kernel.org" , Anilkumar Kolli , "linux-wireless-owner\@vger.kernel.org" Subject: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4 In-Reply-To: <1512143142.25588.17.camel@sipsolutions.net> References: <1512046701-14435-1-git-send-email-akolli@qti.qualcomm.com> <1512046701-14435-3-git-send-email-akolli@qti.qualcomm.com> <87k1y7zqtj.fsf@kamboji.qca.qualcomm.com> <87bmjjzppd.fsf@kamboji.qca.qualcomm.com> <5080a68538fd2d883e15bacaa969661b@codeaurora.org> <87r2se36rq.fsf@toke.dk> <87k1y6y04i.fsf@kamboji.qca.qualcomm.com> <87d13y31r0.fsf@toke.dk> <1512143142.25588.17.camel@sipsolutions.net> Date: Fri, 01 Dec 2017 16:54:12 +0100 Message-ID: <87a7z230m3.fsf@toke.dk> (sfid-20171201_165425_202553_22EA5335) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Johannes Berg writes: > On Fri, 2017-12-01 at 16:29 +0100, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>=20 >> Yeah, figures. Well, maybe we'll just have to support an asynchronous >> callback into mac80211 to register airtime usage. Will probably have to >> add some asynchronicity anyway to avoid doing too much work in the fast >> path. > > I really think we should have that anyway. In fact, perhaps we should > just enforce it that way? Then ath9k would have to do a bit more work, > but it's also the slower of the devices :-) > > But this plays in with the whole multi-queue RX we discussed before. Yeah, that's what I meant by 'add some asynchronicity anyway' :) I guess that once we have an asynchronous scheduler task of some kind, supporting the callback is easy, but pulling the data out of each packet needs more work. But since we'll have to do that for ath9k anyway it becomes more a question of whether it's something that should be supported in mac80211 or if it should be implemented in each driver. But since that logic will have to be written from scratch anyway, is there any reason to not just do it in mac80211 from the beginning? -Toke