All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Laurent Vivier <lvivier@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] migration: clean up xbzrle cache init/destroy
Date: Mon, 23 Oct 2017 13:20:04 +0200	[thread overview]
Message-ID: <87a80i9km3.fsf@secure.laptop> (raw)
In-Reply-To: <20171019063200.19048-4-peterx@redhat.com> (Peter Xu's message of "Thu, 19 Oct 2017 14:31:59 +0800")

Peter Xu <peterx@redhat.com> wrote:
> Let's further simplify ram_init_all() and ram_save_cleanup() by abstract
> all the XBZRLE related codes into their own functions.
>
> When allocating xbzrle cache, we are always very careful on -ENOMEM;
> which makes sense.  Replacing the last g_malloc0() with g_try_malloc0(),
> then refactor the logic a bit.
>
> This patch should be fixing some memory leaks when some memory
> allocation failed for XBZRLE in the past.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

  reply	other threads:[~2017-10-23 11:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-19  6:31 [Qemu-devel] [PATCH 0/4] migration: fixes and cleanups for ram state init Peter Xu
2017-10-19  6:31 ` [Qemu-devel] [PATCH 1/4] migration: provide ram_state_init() Peter Xu
2017-10-23 11:18   ` Juan Quintela
2017-10-19  6:31 ` [Qemu-devel] [PATCH 2/4] migration: provide ram_state_cleanup Peter Xu
2017-10-23 11:19   ` Juan Quintela
2017-10-19  6:31 ` [Qemu-devel] [PATCH 3/4] migration: clean up xbzrle cache init/destroy Peter Xu
2017-10-23 11:20   ` Juan Quintela [this message]
2017-10-19  6:32 ` [Qemu-devel] [PATCH 4/4] migration: new ram_init_bitmaps() Peter Xu
2017-10-23 11:38   ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a80i9km3.fsf@secure.laptop \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.