From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9DFA821945DC1 for ; Sun, 4 Jun 2017 17:59:39 -0700 (PDT) From: "Huang\, Ying" Subject: Re: [PATCH -mm 05/13] block, THP: Make block_device_operations.rw_page support THP References: <20170525064635.2832-1-ying.huang@intel.com> <20170525064635.2832-6-ying.huang@intel.com> <20170602055759.GC5909@linux.intel.com> Date: Mon, 05 Jun 2017 09:00:42 +0800 In-Reply-To: <20170602055759.GC5909@linux.intel.com> (Ross Zwisler's message of "Thu, 1 Jun 2017 23:57:59 -0600") Message-ID: <87a85n1c5h.fsf@yhuang-dev.intel.com> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Ross Zwisler Cc: Jens Axboe , linux-mm@kvack.org, Johannes Weiner , Ross Zwisler , linux-kernel@vger.kernel.org, Minchan Kim , "Huang," Ying" , Andrew Morton ," linux-nvdimm@lists.01.org List-ID: Ross Zwisler writes: > On Thu, May 25, 2017 at 02:46:27PM +0800, Huang, Ying wrote: >> From: Huang Ying >> >> The .rw_page in struct block_device_operations is used by the swap >> subsystem to read/write the page contents from/into the corresponding >> swap slot in the swap device. To support the THP (Transparent Huge >> Page) swap optimization, the .rw_page is enhanced to support to >> read/write THP if possible. >> >> Signed-off-by: "Huang, Ying" >> Cc: Johannes Weiner >> Cc: Minchan Kim >> Cc: Dan Williams >> Cc: Ross Zwisler >> Cc: Vishal L Verma >> Cc: Jens Axboe >> Cc: linux-nvdimm@lists.01.org >> --- >> drivers/block/brd.c | 6 +++++- >> drivers/block/zram/zram_drv.c | 2 ++ >> drivers/nvdimm/btt.c | 4 +++- >> drivers/nvdimm/pmem.c | 42 +++++++++++++++++++++++++++++++----------- >> 4 files changed, 41 insertions(+), 13 deletions(-) > > The changes in brd.c, zram_drv.c and pmem.c look good to me. For those bits > you can add: > > Reviewed-by: Ross Zwisler Thanks! > I think we still want Vishal to make sure that the BTT changes are okay. I > don't know that code well enough to know whether it's safe to throw 512 pages > at btt_[read|write]_pg(). > > Also, Ying, next time can you please CC me (and probably the linux-nvdimm > list) on the whole series? It would give us more context on what the larger > change is, allow us to see the cover letter, allow us to test with all the > patches in the series, etc. It's pretty easy for reviewers to skip over the > patches we don't care about or aren't in our area. Sure. Best Regards, Huang, Ying > Thanks, > - Ross _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f198.google.com (mail-pf0-f198.google.com [209.85.192.198]) by kanga.kvack.org (Postfix) with ESMTP id 38DF76B0292 for ; Sun, 4 Jun 2017 21:00:46 -0400 (EDT) Received: by mail-pf0-f198.google.com with SMTP id k81so1131684pfg.9 for ; Sun, 04 Jun 2017 18:00:46 -0700 (PDT) Received: from mga07.intel.com (mga07.intel.com. [134.134.136.100]) by mx.google.com with ESMTPS id f1si5830688pld.384.2017.06.04.18.00.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Jun 2017 18:00:45 -0700 (PDT) From: "Huang\, Ying" Subject: Re: [PATCH -mm 05/13] block, THP: Make block_device_operations.rw_page support THP References: <20170525064635.2832-1-ying.huang@intel.com> <20170525064635.2832-6-ying.huang@intel.com> <20170602055759.GC5909@linux.intel.com> Date: Mon, 05 Jun 2017 09:00:42 +0800 In-Reply-To: <20170602055759.GC5909@linux.intel.com> (Ross Zwisler's message of "Thu, 1 Jun 2017 23:57:59 -0600") Message-ID: <87a85n1c5h.fsf@yhuang-dev.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Sender: owner-linux-mm@kvack.org List-ID: To: Ross Zwisler Cc: "Huang, Ying" , Andrew Morton , Jens Axboe , Minchan Kim , Ross Zwisler , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Johannes Weiner , linux-nvdimm@lists.01.org Ross Zwisler writes: > On Thu, May 25, 2017 at 02:46:27PM +0800, Huang, Ying wrote: >> From: Huang Ying >> >> The .rw_page in struct block_device_operations is used by the swap >> subsystem to read/write the page contents from/into the corresponding >> swap slot in the swap device. To support the THP (Transparent Huge >> Page) swap optimization, the .rw_page is enhanced to support to >> read/write THP if possible. >> >> Signed-off-by: "Huang, Ying" >> Cc: Johannes Weiner >> Cc: Minchan Kim >> Cc: Dan Williams >> Cc: Ross Zwisler >> Cc: Vishal L Verma >> Cc: Jens Axboe >> Cc: linux-nvdimm@lists.01.org >> --- >> drivers/block/brd.c | 6 +++++- >> drivers/block/zram/zram_drv.c | 2 ++ >> drivers/nvdimm/btt.c | 4 +++- >> drivers/nvdimm/pmem.c | 42 +++++++++++++++++++++++++++++++----------- >> 4 files changed, 41 insertions(+), 13 deletions(-) > > The changes in brd.c, zram_drv.c and pmem.c look good to me. For those bits > you can add: > > Reviewed-by: Ross Zwisler Thanks! > I think we still want Vishal to make sure that the BTT changes are okay. I > don't know that code well enough to know whether it's safe to throw 512 pages > at btt_[read|write]_pg(). > > Also, Ying, next time can you please CC me (and probably the linux-nvdimm > list) on the whole series? It would give us more context on what the larger > change is, allow us to see the cover letter, allow us to test with all the > patches in the series, etc. It's pretty easy for reviewers to skip over the > patches we don't care about or aren't in our area. Sure. Best Regards, Huang, Ying > Thanks, > - Ross -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751241AbdFEBAu (ORCPT ); Sun, 4 Jun 2017 21:00:50 -0400 Received: from mga09.intel.com ([134.134.136.24]:27938 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751163AbdFEBAp (ORCPT ); Sun, 4 Jun 2017 21:00:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,298,1493708400"; d="scan'208";a="109131189" From: "Huang\, Ying" To: Ross Zwisler Cc: "Huang\, Ying" , Andrew Morton , Jens Axboe , Minchan Kim , Ross Zwisler , , , Johannes Weiner , Subject: Re: [PATCH -mm 05/13] block, THP: Make block_device_operations.rw_page support THP References: <20170525064635.2832-1-ying.huang@intel.com> <20170525064635.2832-6-ying.huang@intel.com> <20170602055759.GC5909@linux.intel.com> Date: Mon, 05 Jun 2017 09:00:42 +0800 In-Reply-To: <20170602055759.GC5909@linux.intel.com> (Ross Zwisler's message of "Thu, 1 Jun 2017 23:57:59 -0600") Message-ID: <87a85n1c5h.fsf@yhuang-dev.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ross Zwisler writes: > On Thu, May 25, 2017 at 02:46:27PM +0800, Huang, Ying wrote: >> From: Huang Ying >> >> The .rw_page in struct block_device_operations is used by the swap >> subsystem to read/write the page contents from/into the corresponding >> swap slot in the swap device. To support the THP (Transparent Huge >> Page) swap optimization, the .rw_page is enhanced to support to >> read/write THP if possible. >> >> Signed-off-by: "Huang, Ying" >> Cc: Johannes Weiner >> Cc: Minchan Kim >> Cc: Dan Williams >> Cc: Ross Zwisler >> Cc: Vishal L Verma >> Cc: Jens Axboe >> Cc: linux-nvdimm@lists.01.org >> --- >> drivers/block/brd.c | 6 +++++- >> drivers/block/zram/zram_drv.c | 2 ++ >> drivers/nvdimm/btt.c | 4 +++- >> drivers/nvdimm/pmem.c | 42 +++++++++++++++++++++++++++++++----------- >> 4 files changed, 41 insertions(+), 13 deletions(-) > > The changes in brd.c, zram_drv.c and pmem.c look good to me. For those bits > you can add: > > Reviewed-by: Ross Zwisler Thanks! > I think we still want Vishal to make sure that the BTT changes are okay. I > don't know that code well enough to know whether it's safe to throw 512 pages > at btt_[read|write]_pg(). > > Also, Ying, next time can you please CC me (and probably the linux-nvdimm > list) on the whole series? It would give us more context on what the larger > change is, allow us to see the cover letter, allow us to test with all the > patches in the series, etc. It's pretty easy for reviewers to skip over the > patches we don't care about or aren't in our area. Sure. Best Regards, Huang, Ying > Thanks, > - Ross