All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Mera <dev@michaelmera.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [RESEND] ath10k: fix out of bounds access to local buffer
Date: Wed, 26 Apr 2017 19:32:51 +0900	[thread overview]
Message-ID: <87a873wjak.fsf@michaelmera.com> (raw)
In-Reply-To: <0a7aa133740b4488a19bd95115831988@euamsexm01a.eu.qualcomm.com>

Kalle Valo <kvalo@qca.qualcomm.com> writes:
> I fixed a checkpatch warning in the pending branch:
>
> drivers/net/wireless/ath/ath10k/debug.c:636: spaces preferred around that '-' (ctx:VxV)

Hum... but then you will have a line longer than 80 characters (81), so
another warning.
I prefered this version since I feel that splitting this line would hurt
readability and on the other hand the expression is clearly delimited
by the spaces around the ',' so I don't think spaces around the operator
add any value (except for compliance with the coding style that is).

Thanks,
Michael Mera

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Michael Mera <dev@michaelmera.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [RESEND] ath10k: fix out of bounds access to local buffer
Date: Wed, 26 Apr 2017 19:32:51 +0900	[thread overview]
Message-ID: <87a873wjak.fsf@michaelmera.com> (raw)
In-Reply-To: <0a7aa133740b4488a19bd95115831988@euamsexm01a.eu.qualcomm.com>

Kalle Valo <kvalo@qca.qualcomm.com> writes:
> I fixed a checkpatch warning in the pending branch:
>
> drivers/net/wireless/ath/ath10k/debug.c:636: spaces preferred around that '-' (ctx:VxV)

Hum... but then you will have a line longer than 80 characters (81), so
another warning.
I prefered this version since I feel that splitting this line would hurt
readability and on the other hand the expression is clearly delimited
by the spaces around the ',' so I don't think spaces around the operator
add any value (except for compliance with the coding style that is).

Thanks,
Michael Mera

  reply	other threads:[~2017-04-26 10:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24  7:11 [PATCH RESEND] ath10k: fix out of bounds access to local buffer Michael Mera
2017-04-24  7:11 ` Michael Mera
2017-04-26  9:46 ` [RESEND] " Kalle Valo
2017-04-26  9:46   ` Kalle Valo
2017-04-26 10:32   ` Michael Mera [this message]
2017-04-26 10:32     ` Michael Mera
2017-04-26 11:08     ` Kalle Valo
2017-04-26 11:08       ` Kalle Valo
2017-04-29 10:39       ` Michael Mera
2017-04-29 10:39         ` Michael Mera
2017-05-04 12:59 ` Kalle Valo
2017-05-04 12:59   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a873wjak.fsf@michaelmera.com \
    --to=dev@michaelmera.com \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.