From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE Date: Thu, 30 Mar 2017 09:49:21 +0300 Message-ID: <87a88345u6.fsf@intel.com> References: <20170329092722.6352-1-tobias.regnery@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170329092722.6352-1-tobias.regnery@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Tobias Regnery List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAyOSBNYXIgMjAxNywgVG9iaWFzIFJlZ25lcnkgPHRvYmlhcy5yZWduZXJ5QGdtYWls LmNvbT4gd3JvdGU6Cj4gV2l0aCBDT05GSUdfQUNQST1uIGFuZCBDT05GSUdfQkFDS0xJR0hUX0NM QVNTX0RFVklDRT1uIHdlIHNlZSB0aGUgZm9sbG93aW5nCj4gbGluayBlcnJvciBpbiB0aGUgaTkx NSBkcml2ZXI6Cj4KPiBkcml2ZXJzL2J1aWx0LWluLm86IEluIGZ1bmN0aW9uICdpbnRlbF9iYWNr bGlnaHRfZGV2aWNlX3JlZ2lzdGVyJzoKPiAoLnRleHQrMHgyYTkyMWQpOiB1bmRlZmluZWQgcmVm ZXJlbmNlIHRvICdiYWNrbGlnaHRfZGV2aWNlX3JlZ2lzdGVyJwo+Cj4gRml4IHRoaXMgYnkgcmVt b3ZpbmcgdGhlIGNvbmRpdGlvbiBvbiBBQ1BJIGZyb20gdGhlIGFwcHJvcHJpYXRlIHNlbGVjdAo+ IHN0YXRlbWVudC4KClRoZSByaWdodCBmaXggZm9yIHRoZSBidWlsZCBwcm9ibGVtIGlzIHRvIGFk ZCBlbXB0eSBzdHViIGZ1bmN0aW9ucyBmb3IKQkFDS0xJR0hUX0NMQVNTX0RFVklDRT1uIGluIGlu Y2x1ZGUvbGludXgvYmFja2xpZ2h0LmguIEknbSBmcmFua2x5CnN1cnByaXNlZCBub2JvZHkncyBk b25lIHRoYXQgeWV0LgoKSXQncyBhbm90aGVyIHF1ZXN0aW9uIHdoZXRoZXIgd2Ugc2hvdWxkIHN1 cHBvcnQgYW5kIHNlbGVjdCBiYWNrbGlnaHQgZm9yCkFDUEk9biwgYW5kIHlldCBhbm90aGVyIHF1 ZXN0aW9uIHdoZXRoZXIgd2Ugc2hvdWxkIHN1cHBvcnQgQUNQST1uLgoKQWxzbywgc2VsZWN0aW5n IEJBQ0tMSUdIVF9DTEFTU19ERVZJQ0UgaXMgZnVuZGFtZW50YWxseSBicm9rZW4sIGJ1dApwZW9w bGUgYXJlbid0IGludGVyZXN0ZWQgWzFdLgoKCkJSLApKYW5pLgoKWzFdIGh0dHA6Ly9taWQubWFp bC1hcmNoaXZlLmNvbS8xNDEzNTgwNDAzLTE2MjI1LTEtZ2l0LXNlbmQtZW1haWwtamFuaS5uaWt1 bGFAaW50ZWwuY29tCgo+Cj4gU2lnbmVkLW9mZi1ieTogVG9iaWFzIFJlZ25lcnkgPHRvYmlhcy5y ZWduZXJ5QGdtYWlsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvS2NvbmZpZyB8 IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4K PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvS2NvbmZpZyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L0tjb25maWcKPiBpbmRleCBhNWNkNWRhY2YwNTUuLjUzMmRmNGJiOTI4MyAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9LY29uZmlnCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvS2NvbmZpZwo+IEBAIC0xNSw3ICsxNSw3IEBAIGNvbmZpZyBEUk1fSTkxNQo+ ICAJIyBpOTE1IGRlcGVuZHMgb24gQUNQSV9WSURFTyB3aGVuIEFDUEkgaXMgZW5hYmxlZAo+ICAJ IyBidXQgZm9yIHNlbGVjdCB0byB3b3JrLCBuZWVkIHRvIHNlbGVjdCBBQ1BJX1ZJREVPJ3MgZGVw ZW5kZW5jaWVzLCBpY2sKPiAgCXNlbGVjdCBCQUNLTElHSFRfTENEX1NVUFBPUlQgaWYgQUNQSQo+ IC0Jc2VsZWN0IEJBQ0tMSUdIVF9DTEFTU19ERVZJQ0UgaWYgQUNQSQo+ICsJc2VsZWN0IEJBQ0tM SUdIVF9DTEFTU19ERVZJQ0UKPiAgCXNlbGVjdCBJTlBVVCBpZiBBQ1BJCj4gIAlzZWxlY3QgQUNQ SV9WSURFTyBpZiBBQ1BJCj4gIAlzZWxlY3QgQUNQSV9CVVRUT04gaWYgQUNQSQoKLS0gCkphbmkg TmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933361AbdC3Gw0 (ORCPT ); Thu, 30 Mar 2017 02:52:26 -0400 Received: from mga01.intel.com ([192.55.52.88]:10575 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933171AbdC3GtZ (ORCPT ); Thu, 30 Mar 2017 02:49:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,245,1486454400"; d="scan'208";a="839936351" From: Jani Nikula To: Tobias Regnery , daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Tobias Regnery Subject: Re: [PATCH] drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE In-Reply-To: <20170329092722.6352-1-tobias.regnery@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20170329092722.6352-1-tobias.regnery@gmail.com> Date: Thu, 30 Mar 2017 09:49:21 +0300 Message-ID: <87a88345u6.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Mar 2017, Tobias Regnery wrote: > With CONFIG_ACPI=n and CONFIG_BACKLIGHT_CLASS_DEVICE=n we see the following > link error in the i915 driver: > > drivers/built-in.o: In function 'intel_backlight_device_register': > (.text+0x2a921d): undefined reference to 'backlight_device_register' > > Fix this by removing the condition on ACPI from the appropriate select > statement. The right fix for the build problem is to add empty stub functions for BACKLIGHT_CLASS_DEVICE=n in include/linux/backlight.h. I'm frankly surprised nobody's done that yet. It's another question whether we should support and select backlight for ACPI=n, and yet another question whether we should support ACPI=n. Also, selecting BACKLIGHT_CLASS_DEVICE is fundamentally broken, but people aren't interested [1]. BR, Jani. [1] http://mid.mail-archive.com/1413580403-16225-1-git-send-email-jani.nikula@intel.com > > Signed-off-by: Tobias Regnery > --- > drivers/gpu/drm/i915/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > index a5cd5dacf055..532df4bb9283 100644 > --- a/drivers/gpu/drm/i915/Kconfig > +++ b/drivers/gpu/drm/i915/Kconfig > @@ -15,7 +15,7 @@ config DRM_I915 > # i915 depends on ACPI_VIDEO when ACPI is enabled > # but for select to work, need to select ACPI_VIDEO's dependencies, ick > select BACKLIGHT_LCD_SUPPORT if ACPI > - select BACKLIGHT_CLASS_DEVICE if ACPI > + select BACKLIGHT_CLASS_DEVICE > select INPUT if ACPI > select ACPI_VIDEO if ACPI > select ACPI_BUTTON if ACPI -- Jani Nikula, Intel Open Source Technology Center