From: Marko Rauhamaa <marko.rauhamaa@f-secure.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Jan Kara <jack@suse.cz>, Jeff Layton <jlayton@poochiereds.net>
Subject: Re: fanotify read returns with errno == EOPENSTALE
Date: Thu, 23 Mar 2017 10:13:21 +0200 [thread overview]
Message-ID: <87a88c2yxq.fsf@drapion.f-secure.com> (raw)
In-Reply-To: <CAOQ4uxhTd1j4HLgZFTdr7wwrhjzkVT8QeoXjca_AMZmYHF31sQ@mail.gmail.com> (Amir Goldstein's message of "Wed, 22 Mar 2017 15:39:10 -0400")
Amir Goldstein <amir73il@gmail.com>:
> On Wed, Mar 22, 2017 at 3:31 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>> On Wed, Mar 22, 2017 at 02:20:15PM -0400, Amir Goldstein wrote:
>>
>>> Well, the behavior was changed in kernel 4.7 (and stable kernels) by
>>> commit by Al Viro:
>>> fac7d19 fix EOPENSTALE bug in do_last()
>>>
>>> Since that commit userspace will be able to see this error in
>>> fanotify events.
>>
>> Unless *notify somehow uses do_last() directly, that commit should
>> have no effect on it (and it definitely has no effect on
>> dentry_open() callers)...
>
> Right. I'm being silly :/
>
> Back to Redhat I guess...
I will gladly take the issue to RedHat. However, the discussion so far
confuses me a bit. To confirm, is there a consensus here that EOPENSTALE
should never leak to userspace (through fanotify read anyway)?
If EOPENSTALE *is* a valid possible return from fanotify read, this is
my bug and not RedHat's. In that case, what is the correct recovery?
As for reproduction, I don't yet have one. At the moment, I just need an
authoritative user-space API clarification.
Marko
next prev parent reply other threads:[~2017-03-23 8:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 15:31 fanotify read returns with errno == EOPENSTALE Marko Rauhamaa
2017-03-22 18:01 ` Matthew Wilcox
2017-03-22 18:20 ` Amir Goldstein
2017-03-22 19:17 ` Amir Goldstein
2017-03-22 19:31 ` Al Viro
2017-03-22 19:39 ` Amir Goldstein
2017-03-23 8:13 ` Marko Rauhamaa [this message]
2017-03-23 11:46 ` Amir Goldstein
2017-03-23 11:56 ` Jeff Layton
2017-03-23 12:43 ` Marko Rauhamaa
[not found] ` <8760j02mfz.fsf-q6puBR44SRrF1m+2HNTUelaTQe2KTcn/@public.gmane.org>
2017-03-23 13:47 ` Amir Goldstein
2017-03-23 13:47 ` Amir Goldstein
2017-03-23 13:47 ` Amir Goldstein
[not found] ` <CAOQ4uxja14p02jQurLTGv_fHrs+UBa5qfacrgY_-7tyv6UJqdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-19 13:46 ` Marko Rauhamaa
2017-04-19 13:46 ` Marko Rauhamaa
[not found] ` <87lgqwa4tg.fsf-q6puBR44SRrF1m+2HNTUelaTQe2KTcn/@public.gmane.org>
2017-04-20 11:06 ` Amir Goldstein
2017-04-20 11:06 ` Amir Goldstein
[not found] ` <CAOQ4uxirSfVVYBexXrWccDHnE5oqxNgUh3-X5Ey1w4R=nHXDjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-20 11:33 ` Amir Goldstein
2017-04-20 11:33 ` Amir Goldstein
[not found] ` <CAOQ4uxjA8Z7wnwuHFCKeKT1xz0Gh-qS40Y6cfPi3fAM0MKsRuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-20 12:43 ` Marko Rauhamaa
2017-04-20 12:43 ` Marko Rauhamaa
[not found] ` <87shl38d1x.fsf-q6puBR44SRrF1m+2HNTUelaTQe2KTcn/@public.gmane.org>
2017-04-20 13:34 ` Amir Goldstein
2017-04-20 13:34 ` Amir Goldstein
[not found] ` <CAOQ4uxiJyrvEJMhM1jhiE5pCgP0iA_LL4Eo_h7UY00wkTKhbTg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-21 13:13 ` Marko Rauhamaa
2017-04-21 13:13 ` Marko Rauhamaa
2017-04-20 14:20 ` Jan Kara
[not found] ` <20170420142035.GE22135-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2017-04-20 15:06 ` Amir Goldstein
2017-04-20 15:06 ` Amir Goldstein
[not found] ` <CAOQ4uxgAOJjWP6PHY6WgOkNK0vmaTWnFZN+Jvea7zpjJ_VU8Bw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-22 7:22 ` Amir Goldstein
2017-04-22 7:22 ` Amir Goldstein
[not found] ` <CAOQ4uxgkXz+8=m2o_faAh2g2Z21KhAf67WckgPNWhktz1=DaWA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-24 7:40 ` Marko Rauhamaa
2017-04-24 7:40 ` Marko Rauhamaa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a88c2yxq.fsf@drapion.f-secure.com \
--to=marko.rauhamaa@f-secure.com \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=jlayton@poochiereds.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.