From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] Revert "drm/i915: Implement Link Rate fallback on Link training failure"
Date: Wed, 01 Mar 2017 19:39:21 +0200 [thread overview]
Message-ID: <87a894vquu.fsf@intel.com> (raw)
In-Reply-To: <87d1e0vr1o.fsf@intel.com>
On Wed, 01 Mar 2017, Jani Nikula <jani.nikula@intel.com> wrote:
> On Wed, 01 Mar 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> On Wed, Mar 01, 2017 at 06:17:49PM +0100, Daniel Vetter wrote:
>>> This reverts commit 233ce881dd91fb13eb6b09deefae33168e6ead4c.
>>>
>>> I assumed it's ok, but really should have double-checked - CI caught
>>> tons of fail :(
>
> Considering the velocity of drm-tip, I think any CI results for patches
> have a rather limited best before date. The patch should've been resent
> and gone through testing again before merging.
>
>> For the record, the failure comes from the error message in
>> intel_dp_get_link_train_fallback_values() as take the fallback path. As
>> userspace is informed, we don't need an *ERROR* at that point.
>>
>> The really interesting question is why we are seeing link-training
>> failures in CI at all, and whether igt should be checking and reporting
>> link-status=BAD.
>
> It's possible (I didn't check the logs) this pertains to the failure
> mode I've sometimes seen, where clock recovery fails, but as we continue
> with channel equalization anyway (without this patch), everything
> succeeds there. At worst we need to root cause and fix that issue
> first. :(
Also, possibly to "avoid noise" in CI, the relevant error messages in
intel_dp_link_training_clock_recovery() have been brushed under the
carpet by demoting them to DRM_DEBUG_KMS, so we don't really see this
happening unless we actually eyeball the logs.
>
> BR,
> Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-01 17:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 17:17 [PATCH] Revert "drm/i915: Implement Link Rate fallback on Link training failure" Daniel Vetter
2017-03-01 17:27 ` Chris Wilson
2017-03-01 17:35 ` Jani Nikula
2017-03-01 17:39 ` Jani Nikula [this message]
2017-03-01 17:56 ` Ville Syrjälä
2017-03-01 18:18 ` Jani Nikula
2017-03-01 18:32 ` Ville Syrjälä
2017-03-02 10:07 ` Imre Deak
2017-03-02 10:33 ` Imre Deak
2017-03-02 7:51 ` Daniel Vetter
2017-03-02 10:29 ` Manasi Navare
2017-03-02 8:17 ` Daniel Vetter
2017-03-14 16:57 ` Manasi Navare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a894vquu.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.