From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm: drm_printer: add __printf validation Date: Tue, 21 Feb 2017 10:26:14 +0200 Message-ID: <87a89gkl09.fsf@intel.com> References: <1487610643.2853.6.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 59D336E281 for ; Tue, 21 Feb 2017 08:26:17 +0000 (UTC) In-Reply-To: <1487610643.2853.6.camel@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Joe Perches , Eric Engestrom Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAyMCBGZWIgMjAxNywgSm9lIFBlcmNoZXMgPGpvZUBwZXJjaGVzLmNvbT4gd3JvdGU6 Cj4gT24gTW9uLCAyMDE3LTAyLTIwIGF0IDEyOjE3ICswMDAwLCBFcmljIEVuZ2VzdHJvbSB3cm90 ZToKPj4gT24gV2VkbmVzZGF5LCAyMDE3LTAyLTE1IDE1OjMzOjE4IC0wODAwLCBKb2UgUGVyY2hl cyB3cm90ZToKPj4gPiBkcm1fcHJpbnRmIGRvZXMgbm90IGN1cnJlbnRseSB1c2UgdGhlIGNvbXBp bGVyIHRvIHZlcmlmeQo+PiA+IGZvcm1hdCBhbmQgYXJndW1lbnRzLiAgTWFrZSBpdCBkbyBzby4K Pj4gPiAKPj4gPiBNaXNjZWxsYW5lYToKPj4gPiAKPj4gPiBvIEFkZCBhcHByb3ByaWF0ZSAjaW5j bHVkZSBmaWxlcyBmb3IgX19wcmludGYgYW5kIHN0cnVjdCB2YV9mb3JtYXQKPj4gPiBvIENvbnZl cnQgZGV2X3ByaW50ayB0byBkZXZfaW5mbwo+PiAKPj4gSSB0aGluayB0aGVzZSB1bnJlbGF0ZWQg Y2hhbmdlcyBzaG91bGQgYmUgaW4gNCBwYXRjaGVzOgo+PiAxIC0gYWRkIGFubm90YXRpb24gdG8g Y2hlY2sgdGhlIGZvcm1hdCBzdHJpbmcgYWdhaW5zdCB0aGUgYXJndW1lbnRzCj4+ICAgICAobGlu dXgvY29tcGlsZXIuaCBzaG91bGQgYmUgYWRkZWQgaGVyZSkKPj4gMiAtIGFkZCBtaXNzaW5nIGxp bnV4L3ByaW50ay5oIGhlYWRlciBmb3Igc3RydWN0IHZhX2Zvcm1hdAo+PiAgICAgTm90ZSB0aGF0 IEkgdGhpbmsgYSBmb3J3YXJkIGRlY2xhcmF0aW9uIGlzIG1vcmUgYXBwcm9wcmlhdGUgaGVyZSwg YXMKPj4gICAgIHdlIG9ubHkgdXNlIHBvaW50ZXJzIHRvIHRoaXMgc3RydWN0IGluIHRoaXMgZmls ZSwgd2UgbmV2ZXIgdHJ5IHRvCj4+ICAgICBsb29rIGluc2lkZS4gT24gdGhlIG90aGVyIGhhbmQ6 Cj4+IDMgLSBkcm1fcHJpbnQuYyBuZWVkcyB0aGUgaGVhZGVyIGluIGRybV9wcmludGYoKSwgYnV0 IGFzIGEgc2VwYXJhdGUKPj4gICAgIHBhdGNoCj4+IDQgLSBjb252ZXJ0IGRldl9wcmludGsgdG8g ZGV2X2luZm8gKHlvdSBuZWVkIHRvIGluY2x1ZGUgbGludXgvZGV2aWNlLmgKPj4gICAgIHRoZXJl KQo+Cj4gSSBhbSBub3QgYSBiaWcgZmFuIG9mIG1ha2luZyB0cml2aWFsIHBhdGNoZXMgaW50byBh IHNlcmllcy4KCkl0J3Mgc3RhbmRhcmQgcHJvY2VkdXJlIGluIGtlcm5lbCBkZXZlbG9wbWVudCB0 byBzcGxpdCBvdXQgdW5yZWxhdGVkCmNoYW5nZXMgaW50byBpbmRpdmlkdWFsIHBhdGNoZXMsIHJl Z2FyZGxlc3Mgb2Ygd2hldGhlciB5b3UgdGhpbmsgdGhleQphcmUgdHJpdmlhbCBvciBub3QuIEZv dXIgaXMgcHJvYmFibHkgZXhjZXNzaXZlLCBidXQgeW91IGdldCB0aGUgaWRlYS4KCj4+IFlvdSBj YW4gYWRkIG15IHItYiBvbiBhbGwgZm91ciBwYXRjaGVzIHdoZW4geW91IHNlbmQgdGhlbSB0byB0 aGUgbGlzdCA6KQo+Cj4gSWYgeW91IHdhbnQgdG8gYnJlYWsgaXQgdXAsIGdvIGFoZWFkLgoKWW91 IGtub3cgaG93IHRoaXMgc3R1ZmYgd29ya3MsIHBsZWFzZSBzcGxpdCBpdCB1cCB0byBnZXQgdGhl IHN0dWZmCm1lcmdlZC4KCgpCUiwKSmFuaS4KCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4g U291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751210AbdBUI0V (ORCPT ); Tue, 21 Feb 2017 03:26:21 -0500 Received: from mga06.intel.com ([134.134.136.31]:65134 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750939AbdBUI0S (ORCPT ); Tue, 21 Feb 2017 03:26:18 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,188,1484035200"; d="scan'208";a="826686915" From: Jani Nikula To: Joe Perches , Eric Engestrom Cc: Rob Clark , Daniel Vetter , Sean Paul , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: drm_printer: add __printf validation In-Reply-To: <1487610643.2853.6.camel@perches.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Date: Tue, 21 Feb 2017 10:26:14 +0200 Message-ID: <87a89gkl09.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Feb 2017, Joe Perches wrote: > On Mon, 2017-02-20 at 12:17 +0000, Eric Engestrom wrote: >> On Wednesday, 2017-02-15 15:33:18 -0800, Joe Perches wrote: >> > drm_printf does not currently use the compiler to verify >> > format and arguments. Make it do so. >> > >> > Miscellanea: >> > >> > o Add appropriate #include files for __printf and struct va_format >> > o Convert dev_printk to dev_info >> >> I think these unrelated changes should be in 4 patches: >> 1 - add annotation to check the format string against the arguments >> (linux/compiler.h should be added here) >> 2 - add missing linux/printk.h header for struct va_format >> Note that I think a forward declaration is more appropriate here, as >> we only use pointers to this struct in this file, we never try to >> look inside. On the other hand: >> 3 - drm_print.c needs the header in drm_printf(), but as a separate >> patch >> 4 - convert dev_printk to dev_info (you need to include linux/device.h >> there) > > I am not a big fan of making trivial patches into a series. It's standard procedure in kernel development to split out unrelated changes into individual patches, regardless of whether you think they are trivial or not. Four is probably excessive, but you get the idea. >> You can add my r-b on all four patches when you send them to the list :) > > If you want to break it up, go ahead. You know how this stuff works, please split it up to get the stuff merged. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center