From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Thu, 16 Feb 2017 11:27:47 +0000 Subject: Re: [patch] drm/msm/dsi: free first element on error Message-Id: <87a89mnznw.fsf@intel.com> List-Id: References: <20170216105042.GA25544@mwanda> In-Reply-To: <20170216105042.GA25544@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Rob Clark , Archit Taneja Cc: linux-arm-msm@vger.kernel.org, Wei Yongjun , freedreno@lists.freedesktop.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org On Thu, 16 Feb 2017, Dan Carpenter wrote: > We want to free msm_host->bus_clks[0] so the > should be >=. > > Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c > index 1fc07ce24686..239e79b39a45 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -437,7 +437,7 @@ static int dsi_bus_clk_enable(struct msm_dsi_host *msm_host) > > return 0; > err: > - for (; i > 0; i--) > + for (; i >= 0; i--) > clk_disable_unprepare(msm_host->bus_clks[i]); By the looks of it this is also wrong. I didn't look at the functions, but you probably don't want to unprepare something where prepare failed, i.e. you want to -1 both the start and end offsets. Perhaps the right fix is while (i--) clk_disable_unprepare(msm_host->bus_clks[i]); which also seems to be widely used on error paths. BR, Jani. > > return ret; > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [patch] drm/msm/dsi: free first element on error Date: Thu, 16 Feb 2017 13:27:47 +0200 Message-ID: <87a89mnznw.fsf@intel.com> References: <20170216105042.GA25544@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170216105042.GA25544@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter , Rob Clark , Archit Taneja Cc: linux-arm-msm@vger.kernel.org, Wei Yongjun , freedreno@lists.freedesktop.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: linux-arm-msm@vger.kernel.org T24gVGh1LCAxNiBGZWIgMjAxNywgRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUu Y29tPiB3cm90ZToKPiBXZSB3YW50IHRvIGZyZWUgbXNtX2hvc3QtPmJ1c19jbGtzWzBdIHNvIHRo ZSA+IHNob3VsZCBiZSA+PS4KPgo+IEZpeGVzOiA2ZTBlYjUyZWJhOWUgKCJkcm0vbXNtL2RzaTog UGFyc2UgYnVzIGNsb2NrcyBmcm9tIGEgbGlzdCIpCj4gU2lnbmVkLW9mZi1ieTogRGFuIENhcnBl bnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9tc20vZHNpL2RzaV9ob3N0LmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2RzaS9kc2lf aG9zdC5jCj4gaW5kZXggMWZjMDdjZTI0Njg2Li4yMzllNzliMzlhNDUgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL21zbS9kc2kvZHNpX2hvc3QuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9tc20vZHNpL2RzaV9ob3N0LmMKPiBAQCAtNDM3LDcgKzQzNyw3IEBAIHN0YXRpYyBpbnQgZHNp X2J1c19jbGtfZW5hYmxlKHN0cnVjdCBtc21fZHNpX2hvc3QgKm1zbV9ob3N0KQo+ICAKPiAgCXJl dHVybiAwOwo+ICBlcnI6Cj4gLQlmb3IgKDsgaSA+IDA7IGktLSkKPiArCWZvciAoOyBpID49IDA7 IGktLSkKPiAgCQljbGtfZGlzYWJsZV91bnByZXBhcmUobXNtX2hvc3QtPmJ1c19jbGtzW2ldKTsK CkJ5IHRoZSBsb29rcyBvZiBpdCB0aGlzIGlzIGFsc28gd3JvbmcuIEkgZGlkbid0IGxvb2sgYXQg dGhlIGZ1bmN0aW9ucywKYnV0IHlvdSBwcm9iYWJseSBkb24ndCB3YW50IHRvIHVucHJlcGFyZSBz b21ldGhpbmcgd2hlcmUgcHJlcGFyZSBmYWlsZWQsCmkuZS4geW91IHdhbnQgdG8gLTEgYm90aCB0 aGUgc3RhcnQgYW5kIGVuZCBvZmZzZXRzLiBQZXJoYXBzIHRoZSByaWdodApmaXggaXMKCgl3aGls ZSAoaS0tKQoJCWNsa19kaXNhYmxlX3VucHJlcGFyZShtc21faG9zdC0+YnVzX2Nsa3NbaV0pOwoK d2hpY2ggYWxzbyBzZWVtcyB0byBiZSB3aWRlbHkgdXNlZCBvbiBlcnJvciBwYXRocy4KCkJSLApK YW5pLgoKCj4gIAo+ICAJcmV0dXJuIHJldDsKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3Vy Y2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg==