From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: armada388-clearfog: fix SPI flash #size-cells
Date: Wed, 04 Jan 2017 11:37:06 +0100 [thread overview]
Message-ID: <87a8b7f6wd.fsf@free-electrons.com> (raw)
In-Reply-To: <E1cO41M-0007xc-Id@rmk-PC.armlinux.org.uk> (Russell King's message of "Mon, 02 Jan 2017 14:55:32 +0000")
Hi Russell,
On lun., janv. 02 2017, Russell King <rmk+kernel@armlinux.org.uk> wrote:
> The SPI flash #size-cells is specified in the binding documentation to
> have value 1, but we were setting it to zero. This wasn't causing any
> problem as we do not list any partitions, but it's worth specifying
> correctly if we're going to specify it at all.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-388-clearfog.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-388-clearfog.dts b/arch/arm/boot/dts/armada-388-clearfog.dts
> index 71ce201c903e..3e7c3a6237c3 100644
> --- a/arch/arm/boot/dts/armada-388-clearfog.dts
> +++ b/arch/arm/boot/dts/armada-388-clearfog.dts
> @@ -437,7 +437,7 @@
>
> spi-flash at 0 {
> #address-cells = <1>;
> - #size-cells = <0>;
> + #size-cells = <1>;
> compatible = "w25q32", "jedec,spi-nor";
> reg = <0>; /* Chip select 0 */
> spi-max-frequency = <3000000>;
> --
> 2.7.4
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Russell King <rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: dts: armada388-clearfog: fix SPI flash #size-cells
Date: Wed, 04 Jan 2017 11:37:06 +0100 [thread overview]
Message-ID: <87a8b7f6wd.fsf@free-electrons.com> (raw)
In-Reply-To: <E1cO41M-0007xc-Id-eh5Bv4kxaXIk46pC+1QYvQNdhmdF6hFW@public.gmane.org> (Russell King's message of "Mon, 02 Jan 2017 14:55:32 +0000")
Hi Russell,
On lun., janv. 02 2017, Russell King <rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org> wrote:
> The SPI flash #size-cells is specified in the binding documentation to
> have value 1, but we were setting it to zero. This wasn't causing any
> problem as we do not list any partitions, but it's worth specifying
> correctly if we're going to specify it at all.
>
> Signed-off-by: Russell King <rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-388-clearfog.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-388-clearfog.dts b/arch/arm/boot/dts/armada-388-clearfog.dts
> index 71ce201c903e..3e7c3a6237c3 100644
> --- a/arch/arm/boot/dts/armada-388-clearfog.dts
> +++ b/arch/arm/boot/dts/armada-388-clearfog.dts
> @@ -437,7 +437,7 @@
>
> spi-flash@0 {
> #address-cells = <1>;
> - #size-cells = <0>;
> + #size-cells = <1>;
> compatible = "w25q32", "jedec,spi-nor";
> reg = <0>; /* Chip select 0 */
> spi-max-frequency = <3000000>;
> --
> 2.7.4
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-04 10:37 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 14:55 [PATCH] ARM: dts: armada388-clearfog: fix SPI flash #size-cells Russell King
2017-01-02 14:55 ` Russell King
2017-01-02 14:57 ` [PATCH 0/9] ARM: dts: armada388: Introduce Clearfog Base DT Russell King
2017-01-02 14:57 ` Russell King
2017-01-02 14:58 ` [PATCH 1/9] ARM: dts: armada388-clearfog: move SPI flash into microsom Russell King
2017-01-02 14:58 ` Russell King
2017-01-02 14:58 ` [PATCH 2/9] ARM: dts: armada388-clearfog: move sdhci pinctrl node to microsom Russell King
2017-01-02 14:58 ` Russell King
2017-01-02 14:58 ` [PATCH 3/9] ARM: dts: armada388-clearfog: split clearfog DTS file Russell King
2017-01-02 14:58 ` Russell King
2017-01-02 14:58 ` [PATCH 4/9] ARM: dts: armada388-clearfog: move DSA switch Russell King
2017-01-02 14:58 ` Russell King
2017-01-02 14:59 ` [PATCH 5/9] ARM: dts: armada388-clearfog: move second PCIe port Russell King
2017-01-02 14:59 ` Russell King
2017-01-02 14:59 ` [PATCH 6/9] ARM: dts: armada388-clearfog: move SPI CS1 Russell King
2017-01-02 14:59 ` Russell King
2017-01-02 14:59 ` [PATCH 7/9] ARM: dts: armada388-clearfog: move rear button Russell King
2017-01-02 14:59 ` Russell King
2017-01-02 14:59 ` [PATCH 8/9] ARM: dts: armada388-clearfog: add base model DTS file Russell King
2017-01-02 14:59 ` Russell King
2017-01-02 14:59 ` [PATCH 9/9] ARM: dts: armada388-clearfog: add pro " Russell King
2017-01-02 14:59 ` Russell King
2017-01-02 15:25 ` [PATCH 0/5] ARM: dts: armada388: rework clearfog's .dtsi references Russell King
2017-01-02 15:25 ` Russell King
2017-01-02 15:27 ` [PATCH 1/5] ARM: dts: armada388-clearfog: add phy reset gpio-hog Russell King
2017-01-02 15:27 ` Russell King
2017-01-04 16:26 ` Gregory CLEMENT
2017-01-04 16:26 ` Gregory CLEMENT
2017-01-05 10:16 ` Russell King - ARM Linux
2017-01-05 10:16 ` Russell King - ARM Linux
2017-01-05 10:29 ` Gregory CLEMENT
2017-01-05 10:29 ` Gregory CLEMENT
2017-01-05 10:31 ` Russell King - ARM Linux
2017-01-05 10:31 ` Russell King - ARM Linux
2017-01-05 13:04 ` Gregory CLEMENT
2017-01-05 13:04 ` Gregory CLEMENT
2017-01-02 15:27 ` [PATCH 2/5] ARM: dts: armada388-clearfog: move device specific pinctrl nodes Russell King
2017-01-02 15:27 ` Russell King
2017-01-02 15:27 ` [PATCH 3/5] ARM: dts: armada388-clearfog: move I2C nodes Russell King
2017-01-02 15:27 ` Russell King
2017-01-02 15:27 ` [PATCH 4/5] ARM: dts: armada388-clearfog: move ethernet related nodes Russell King
2017-01-02 15:27 ` Russell King
2017-01-02 15:27 ` [PATCH 5/5] ARM: dts: armada388-clearfog: move uart nodes Russell King
2017-01-02 15:27 ` Russell King
2017-01-04 16:31 ` [PATCH 0/5] ARM: dts: armada388: rework clearfog's .dtsi references Gregory CLEMENT
2017-01-04 16:31 ` Gregory CLEMENT
2017-01-04 15:48 ` [PATCH 0/9] ARM: dts: armada388: Introduce Clearfog Base DT Gregory CLEMENT
2017-01-04 15:48 ` Gregory CLEMENT
2017-01-04 10:37 ` Gregory CLEMENT [this message]
2017-01-04 10:37 ` [PATCH] ARM: dts: armada388-clearfog: fix SPI flash #size-cells Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8b7f6wd.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.