From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v11 3/4] drm/i915: Use new CRC debugfs API Date: Tue, 15 Nov 2016 10:27:33 +0200 Message-ID: <87a8d12lmy.fsf@intel.com> References: <1475767268-14379-1-git-send-email-tomeu.vizoso@collabora.com> <1475767268-14379-4-git-send-email-tomeu.vizoso@collabora.com> <87inrq2vee.fsf@intel.com> <20161115071609.GI8202@suiko.acc.umu.se> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20161115071609.GI8202@suiko.acc.umu.se> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: David Weinehall Cc: Tomeu Vizoso , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAxNSBOb3YgMjAxNiwgRGF2aWQgV2VpbmVoYWxsIDx0YW9Aa2VybmVsLm9yZz4gd3Jv dGU6Cj4gT24gTW9uLCBOb3YgMTQsIDIwMTYgYXQgMTI6NDQ6MjVQTSArMDIwMCwgSmFuaSBOaWt1 bGEgd3JvdGU6Cj4+IE9uIFRodSwgMDYgT2N0IDIwMTYsIFRvbWV1IFZpem9zbyA8dG9tZXUudml6 b3NvQGNvbGxhYm9yYS5jb20+IHdyb3RlOgo+PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMKPj4gPiBpbmRleCAyM2E2YzcyMTNlY2EuLjc0MTJhMDVmYTVkOSAxMDA2NDQKPj4gPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gPiBAQCAtMTQ2MzYsNiArMTQ2MzYs NyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9jcnRjX2Z1bmNzIGludGVsX2NydGNfZnVuY3Mg PSB7Cj4+ID4gIAkucGFnZV9mbGlwID0gaW50ZWxfY3J0Y19wYWdlX2ZsaXAsCj4+ID4gIAkuYXRv bWljX2R1cGxpY2F0ZV9zdGF0ZSA9IGludGVsX2NydGNfZHVwbGljYXRlX3N0YXRlLAo+PiA+ICAJ LmF0b21pY19kZXN0cm95X3N0YXRlID0gaW50ZWxfY3J0Y19kZXN0cm95X3N0YXRlLAo+PiA+ICsJ LnNldF9jcmNfc291cmNlID0gaW50ZWxfY3J0Y19zZXRfY3JjX3NvdXJjZSwKPj4gPiAgfTsKPj4g PiAgCj4+ID4gIC8qKgo+PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4+ID4gaW5kZXggNzM3 MjYxYjA5MTEwLi4zMTg5NGI3YzY1MTcgMTAwNjQ0Cj4+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHJ2LmgKPj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cnYuaAo+PiA+IEBAIC0xODQ0LDYgKzE4NDQsMTQgQEAgdm9pZCBpbnRlbF9jb2xvcl9sb2FkX2x1 dHMoc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKTsKPj4gPiAgLyogaW50ZWxfcGlw ZV9jcmMuYyAqLwo+PiA+ICBpbnQgaW50ZWxfcGlwZV9jcmNfY3JlYXRlKHN0cnVjdCBkcm1fbWlu b3IgKm1pbm9yKTsKPj4gPiAgdm9pZCBpbnRlbF9waXBlX2NyY19jbGVhbnVwKHN0cnVjdCBkcm1f bWlub3IgKm1pbm9yKTsKPj4gPiArI2lmZGVmIENPTkZJR19ERUJVR19GUwo+PiA+ICtpbnQgaW50 ZWxfY3J0Y19zZXRfY3JjX3NvdXJjZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsIGNvbnN0IGNoYXIg KnNvdXJjZV9uYW1lLAo+PiA+ICsJCQkgICAgICBzaXplX3QgKnZhbHVlc19jbnQpOwo+PiA+ICsj ZWxzZQo+PiA+ICtzdGF0aWMgaW5saW5lIGludCBpbnRlbF9jcnRjX3NldF9jcmNfc291cmNlKHN0 cnVjdCBkcm1fY3J0YyAqY3J0YywKPj4gPiArCQkJCQkgICAgY29uc3QgY2hhciAqc291cmNlX25h bWUsCj4+ID4gKwkJCQkJICAgIHNpemVfdCAqdmFsdWVzX2NudCkgeyByZXR1cm4gMDsgfQo+PiA+ ICsjZW5kaWYKPj4gCj4+ICJpbmxpbmUiIGhlcmUgZG9lc24ndCB3b3JrIGJlY2F1c2UgaXQncyB1 c2VkIGFzIGEgZnVuY3Rpb24gcG9pbnRlci4KPj4gCj4+IElzIGl0IGJldHRlciB0byBoYXZlIGEg ZnVuY3Rpb24gdGhhdCByZXR1cm5zIDAgZm9yIC5zZXRfY3JjX3NvdXJjZSwgb3IKPj4gdG8gc2V0 IC5zZXRfY3JjX3NvdXJjZSB0byBOVUxMIHdoZW4gQ09ORklHX0RFQlVHX0ZTPW4/Cj4KPiBJJ2Qg c2F5IHRoYXQgd2hlbmV2ZXIgd2UgaGF2ZSBhIGZ1bmN0aW9uIHBvaW50ZXIgd2Ugc2hvdWxkIGhh dmUgYSBkdW1teQo+IGZ1bmN0aW9uIHdpdGhvdXQgc2lkZS1lZmZlY3RzIGZvciB0aGlzIGtpbmQg b2YgdGhpbmdzLgoKV2hvZXZlciBjYWxscyAuc2V0X2NyY19zb3VyY2UgY291bGQgZG8gc21hcnRl ciB0aGluZ3MgZGVwZW5kaW5nIG9uIHRoZQpob29rIG5vdCBiZWluZyB0aGVyZSB2cy4ganVzdCBz aWxlbnRseSBwbHVuZ2luZyBvbi4KCkJSLApKYW5pLgoKCj4KPgo+IEtpbmQgcmVnYXJkcywgRGF2 aWQKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755574AbcKOI1j (ORCPT ); Tue, 15 Nov 2016 03:27:39 -0500 Received: from mga05.intel.com ([192.55.52.43]:12352 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751567AbcKOI1g (ORCPT ); Tue, 15 Nov 2016 03:27:36 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,641,1473145200"; d="scan'208";a="786572750" From: Jani Nikula To: David Weinehall Cc: Tomeu Vizoso , linux-kernel@vger.kernel.org, David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Thierry Reding , Daniel Vetter Subject: Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API In-Reply-To: <20161115071609.GI8202@suiko.acc.umu.se> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1475767268-14379-1-git-send-email-tomeu.vizoso@collabora.com> <1475767268-14379-4-git-send-email-tomeu.vizoso@collabora.com> <87inrq2vee.fsf@intel.com> <20161115071609.GI8202@suiko.acc.umu.se> Date: Tue, 15 Nov 2016 10:27:33 +0200 Message-ID: <87a8d12lmy.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Nov 2016, David Weinehall wrote: > On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wrote: >> On Thu, 06 Oct 2016, Tomeu Vizoso wrote: >> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c >> > index 23a6c7213eca..7412a05fa5d9 100644 >> > --- a/drivers/gpu/drm/i915/intel_display.c >> > +++ b/drivers/gpu/drm/i915/intel_display.c >> > @@ -14636,6 +14636,7 @@ static const struct drm_crtc_funcs intel_crtc_funcs = { >> > .page_flip = intel_crtc_page_flip, >> > .atomic_duplicate_state = intel_crtc_duplicate_state, >> > .atomic_destroy_state = intel_crtc_destroy_state, >> > + .set_crc_source = intel_crtc_set_crc_source, >> > }; >> > >> > /** >> > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h >> > index 737261b09110..31894b7c6517 100644 >> > --- a/drivers/gpu/drm/i915/intel_drv.h >> > +++ b/drivers/gpu/drm/i915/intel_drv.h >> > @@ -1844,6 +1844,14 @@ void intel_color_load_luts(struct drm_crtc_state *crtc_state); >> > /* intel_pipe_crc.c */ >> > int intel_pipe_crc_create(struct drm_minor *minor); >> > void intel_pipe_crc_cleanup(struct drm_minor *minor); >> > +#ifdef CONFIG_DEBUG_FS >> > +int intel_crtc_set_crc_source(struct drm_crtc *crtc, const char *source_name, >> > + size_t *values_cnt); >> > +#else >> > +static inline int intel_crtc_set_crc_source(struct drm_crtc *crtc, >> > + const char *source_name, >> > + size_t *values_cnt) { return 0; } >> > +#endif >> >> "inline" here doesn't work because it's used as a function pointer. >> >> Is it better to have a function that returns 0 for .set_crc_source, or >> to set .set_crc_source to NULL when CONFIG_DEBUG_FS=n? > > I'd say that whenever we have a function pointer we should have a dummy > function without side-effects for this kind of things. Whoever calls .set_crc_source could do smarter things depending on the hook not being there vs. just silently plunging on. BR, Jani. > > > Kind regards, David -- Jani Nikula, Intel Open Source Technology Center