From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55542)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bzOPx-0005wb-0B
	for qemu-devel@nongnu.org; Wed, 26 Oct 2016 09:38:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bzOPt-00025F-NP
	for qemu-devel@nongnu.org; Wed, 26 Oct 2016 09:38:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60694)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1bzOPt-00025A-IJ
	for qemu-devel@nongnu.org; Wed, 26 Oct 2016 09:38:53 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id C16C43D950
	for <qemu-devel@nongnu.org>; Wed, 26 Oct 2016 13:38:52 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <20160925181836.18293-1-marcandre.lureau@redhat.com>
	<20160925181836.18293-5-marcandre.lureau@redhat.com>
Date: Wed, 26 Oct 2016 15:38:50 +0200
In-Reply-To: <20160925181836.18293-5-marcandre.lureau@redhat.com>
	(=?utf-8?Q?=22Marc-Andr=C3=A9?=
	Lureau"'s message of "Sun, 25 Sep 2016 22:18:29 +0400")
Message-ID: <87a8drmdqt.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 04/11] qapi: fix @ACPI sections
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org

Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com> writes:

> This helps the doc parser.
>
> Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
> ---
>  qapi-schema.json | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 3091993..3ac8637 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -4414,14 +4414,16 @@
>  ##
>  { 'command': 'query-memory-devices', 'returns': ['MemoryDeviceInfo'] }
>=20=20
> -## @ACPISlotType
> +##
> +# @ACPISlotType
>  #
>  # @DIMM: memory slot
>  # @CPU: logical CPU slot (since 2.7)
>  #
>  { 'enum': 'ACPISlotType', 'data': [ 'DIMM', 'CPU' ] }
>=20=20
> -## @ACPIOSTInfo
> +##
> +# @ACPIOSTInfo
>  #
>  # OSPM Status Indication for a device
>  # For description of possible values of @source and @status fields

Could be squashed into PATCH 02.

Another, unrelated thing to clean up while you're at it: { 'include':
'qapi/rocker.json' } is in the middle of qapi-schema.json for no obvious
reason.  Let's move it next to the other includes, in a separate patch.

There's also inconsistent whitespace use, but I think that's best left
for another day.