All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu OTHACEHE <m.othacehe@gmail.com>
To: Michal Marek <mmarek@suse.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Al Viro <viro@zeniv.linux.org.uk>,
	LKML <linux-kernel@vger.kernel.org>,
	lkp@01.org
Subject: Re: [lkp] [x86] 784d5699ed: kmsg.ip_tables:no_symbol_version_for_copy_from_user
Date: Fri, 14 Oct 2016 09:27:25 +0200	[thread overview]
Message-ID: <87a8e7jspu.fsf@gmail.com> (raw)
In-Reply-To: <57FCE5A2.9090602@suse.com>


Hi Michal,

Sorry for late reply. My toolchain in arch linux gcc version 6.2.1
20160830. I used defconfig (x86_64), with CONFIG_MODVERSIONS=y.

I'm understanding better what's happening here. Running:

nm arch/x86/lib/clear_page_64.o
gives,
0000000000000000 T clear_page
0000000000000050 T clear_page_c_e
0000000000000010 T clear_page_orig
                 w __crc_clear_page
0000000000000000 r __kcrctab_clear_page
0000000000000000 r __kstrtab_clear_page
0000000000000000 R __ksymtab_clear_page

but running

nm vmlinux|grep __crc_clear_page
gives,
0000000051fac2d3 A __crc_clear_page_dirty_for_io

So the weak symbol "__crc_clear_page" is not copied in vmlinux during
linking. modpost uses __crc_* symbols to extract crc. Not founding
those crc, it doesn't include symbols in mod.c modversion_info struct.

It seems to be a linker bug. I also tested linking:
<main.c>
int main() {
return 0;
}

and
<test.S>
.section test,"a"
__kcrctab_test:
.quad __test
.weak __test

Linking main.o and test.o,
* weak symbol "__test" appears in a.out with gcc 5.4.0
* weak symbol "__test" *does not* appear in a.out with gcc 6.2.1

I'll try to find if there is a related bug report in gcc.

Thanks,

Mathieu

  reply	other threads:[~2016-10-14  7:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-20  2:55 [x86] 784d5699ed: kmsg.ip_tables:no_symbol_version_for_copy_from_user kernel test robot
2016-09-20  2:55 ` [lkp] " kernel test robot
2016-09-29 23:26 ` Stephen Rothwell
2016-09-29 23:26   ` [lkp] " Stephen Rothwell
2016-10-09  9:46   ` Mathieu OTHACEHE
2016-10-11 13:10   ` Michal Marek
2016-10-11 13:10     ` [lkp] " Michal Marek
2016-10-11 13:14     ` Michal Marek
2016-10-11 13:14       ` [lkp] " Michal Marek
2016-10-14  7:27       ` Mathieu OTHACEHE [this message]
2016-10-18  8:00       ` Ye Xiaolong
2016-10-18  8:00         ` [LKP] [lkp] " Ye Xiaolong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8e7jspu.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=mmarek@suse.com \
    --cc=sfr@canb.auug.org.au \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.