From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bu1fG-0003kw-Cn for qemu-devel@nongnu.org; Tue, 11 Oct 2016 14:20:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bu1fA-0003h8-CX for qemu-devel@nongnu.org; Tue, 11 Oct 2016 14:20:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bu1fA-0003h1-62 for qemu-devel@nongnu.org; Tue, 11 Oct 2016 14:20:28 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 74CB9C05A293 for ; Tue, 11 Oct 2016 18:20:27 +0000 (UTC) From: Markus Armbruster References: <20161011174121.815-1-marcandre.lureau@redhat.com> Date: Tue, 11 Oct 2016 20:20:25 +0200 In-Reply-To: <20161011174121.815-1-marcandre.lureau@redhat.com> (=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Tue, 11 Oct 2016 21:41:21 +0400") Message-ID: <87a8ea693q.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCHv2] monitor: deprecate 'default' option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, David Alan Gilbert , Paolo Bonzini Marc-Andr=C3=A9 Lureau writes: > This option does nothing since commit 06ac27f. Deprecate it. > > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > vl.c | 11 +++-------- > include/monitor/monitor.h | 2 +- > qemu-options.hx | 8 ++++---- > 3 files changed, 8 insertions(+), 13 deletions(-) > > v2: > - update after Markus review > - fix error on default monitor > - drop from qemu-trivial Suggest to squash in the appended patch. Reviewed-by: Markus Armbruster Could go via David, Paolo or myself. David, do you have anything pending right now? diff --git a/monitor.c b/monitor.c index b07f254..ab9e911 100644 --- a/monitor.c +++ b/monitor.c @@ -4093,7 +4093,7 @@ QemuOptsList qemu_mon_opts =3D { .name =3D "chardev", .type =3D QEMU_OPT_STRING, },{ - .name =3D "default", + .name =3D "default", /* deprecated */ .type =3D QEMU_OPT_BOOL, },{ .name =3D "pretty",