From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/1] drm/gma500: dont expose stack, mrst_lvds_find_best_pll Date: Mon, 22 Aug 2016 11:39:48 +0300 Message-ID: <87a8g5urhn.fsf@intel.com> References: <1471809437-4377-1-git-send-email-xypron.glpk@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE1C06E3EB for ; Mon, 22 Aug 2016 08:39:51 +0000 (UTC) In-Reply-To: <1471809437-4377-1-git-send-email-xypron.glpk@gmx.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Patrik Jakobsson Cc: Joe Perches , Heinrich Schuchardt , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCAyMSBBdWcgMjAxNiwgSGVpbnJpY2ggU2NodWNoYXJkdCA8eHlwcm9uLmdscGtAZ214 LmRlPiB3cm90ZToKPiBBbGwgY29tcG9uZW50cyBvZiB2YXJpYWJsZSBjbG9jayBzaG91bGQgYmUg aW5pdGlhbGl6ZWQKPiB0byBhdm9pZCBieXRlcyBmcm9tIHRoZSBrZXJuZWwgc3RhY2sgdG8gYmUg ZXhwb3NlZC4KPgo+IFJlcG9ydGVkLWJ5OiBKb2UgUGVyY2hlcyA8am9lQHBlcmNoZXMuY29tPgo+ IFNpZ25lZC1vZmYtYnk6IEhlaW5yaWNoIFNjaHVjaGFyZHQgPHh5cHJvbi5nbHBrQGdteC5kZT4K PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2dtYTUwMC9vYWt0cmFpbF9jcnRjLmMgfCAxICsKPiAg MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2dtYTUwMC9vYWt0cmFpbF9jcnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vZ21hNTAwL29h a3RyYWlsX2NydGMuYwo+IGluZGV4IDI4YmQ4ZjMuLjAyNzdkODUgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2dtYTUwMC9vYWt0cmFpbF9jcnRjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vZ21hNTAwL29ha3RyYWlsX2NydGMuYwo+IEBAIC0xOTUsNiArMTk1LDcgQEAgc3RhdGljIGJv b2wgbXJzdF9sdmRzX2ZpbmRfYmVzdF9wbGwoY29uc3Qgc3RydWN0IGdtYV9saW1pdF90ICpsaW1p dCwKPiAgCXN0cnVjdCBnbWFfY2xvY2tfdCBjbG9jazsKPiAgCWludCBlcnIgPSB0YXJnZXQ7Cj4g IAo+ICsJbWVtc2V0KGNsb2NrLCAwLCBzaXplb2Yoc3RydWN0IGdtYV9jbG9ja190KSk7CgpBZ2Fp biwgZGlkIHlvdSBhY3R1YWxseSBidWlsZCB0aGlzPyBUaGlzIGlzIGh1cnRpbmcgbm90IGhlbHBp bmcgdXMuIEl0Cm1ha2VzIG1lIHRoaW5rIHlvdSBkaWRuJ3QgdHJ5IHlvdXIgb3RoZXIgcGF0Y2hl cyBlaXRoZXIuCgpCUiwKSmFuaS4KCgo+ICAJbWVtc2V0KGJlc3RfY2xvY2ssIDAsIHNpemVvZigq YmVzdF9jbG9jaykpOwo+ICAKPiAgCWZvciAoY2xvY2subSA9IGxpbWl0LT5tLm1pbjsgY2xvY2su bSA8PSBsaW1pdC0+bS5tYXg7IGNsb2NrLm0rKykgewoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBP cGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754441AbcHVIjx (ORCPT ); Mon, 22 Aug 2016 04:39:53 -0400 Received: from mga04.intel.com ([192.55.52.120]:18077 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752152AbcHVIjv (ORCPT ); Mon, 22 Aug 2016 04:39:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,559,1464678000"; d="scan'208";a="1045240162" From: Jani Nikula To: Heinrich Schuchardt , Patrik Jakobsson Cc: Joe Perches , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Heinrich Schuchardt Subject: Re: [PATCH 1/1] drm/gma500: dont expose stack, mrst_lvds_find_best_pll In-Reply-To: <1471809437-4377-1-git-send-email-xypron.glpk@gmx.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1471809437-4377-1-git-send-email-xypron.glpk@gmx.de> User-Agent: Notmuch/0.22.1+63~g648dcc7 (https://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 22 Aug 2016 11:39:48 +0300 Message-ID: <87a8g5urhn.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 21 Aug 2016, Heinrich Schuchardt wrote: > All components of variable clock should be initialized > to avoid bytes from the kernel stack to be exposed. > > Reported-by: Joe Perches > Signed-off-by: Heinrich Schuchardt > --- > drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c > index 28bd8f3..0277d85 100644 > --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c > +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c > @@ -195,6 +195,7 @@ static bool mrst_lvds_find_best_pll(const struct gma_limit_t *limit, > struct gma_clock_t clock; > int err = target; > > + memset(clock, 0, sizeof(struct gma_clock_t)); Again, did you actually build this? This is hurting not helping us. It makes me think you didn't try your other patches either. BR, Jani. > memset(best_clock, 0, sizeof(*best_clock)); > > for (clock.m = limit->m.min; clock.m <= limit->m.max; clock.m++) { -- Jani Nikula, Intel Open Source Technology Center