From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48144)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1baRFx-0005H6-OG
	for qemu-devel@nongnu.org; Thu, 18 Aug 2016 13:37:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1baRFs-0005qB-Do
	for qemu-devel@nongnu.org; Thu, 18 Aug 2016 13:37:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43040)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1baRFs-0005q7-8G
	for qemu-devel@nongnu.org; Thu, 18 Aug 2016 13:37:24 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1471529754-29690-1-git-send-email-caoj.fnst@cn.fujitsu.com>
	<73BF031C-2ED4-421C-AFFA-00B8FA3811ED@daynix.com>
	<87inuyqbbn.fsf@dusky.pond.sub.org>
Date: Thu, 18 Aug 2016 19:37:20 +0200
In-Reply-To: <87inuyqbbn.fsf@dusky.pond.sub.org> (Markus Armbruster's message
	of "Thu, 18 Aug 2016 18:41:16 +0200")
Message-ID: <87a8gaou5r.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] e1000e: remove internal interrupt flag
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dmitry Fleytman <dmitry@daynix.com>
Cc: Cao jin <caoj.fnst@cn.fujitsu.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Peter Maydell <peter.maydell@linaro.org>

Markus Armbruster <armbru@redhat.com> writes:

> Dmitry Fleytman <dmitry@daynix.com> writes:
>
>>> On 18 Aug 2016, at 17:15, Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
[...]
>>> @@ -601,7 +596,6 @@ static const VMStateDescription e1000e_vmstate = {
>>>         VMSTATE_MSIX(parent_obj, E1000EState),
>>> 
>>>         VMSTATE_UINT32(ioaddr, E1000EState),
>>> -       VMSTATE_UINT32(intr_state, E1000EState),
>
> We can still do this, because as Paolo pointed out, no released version
> of QEMU had this device.

Which means we better get this into 2.7.0.  Thoughts?

>>>         VMSTATE_UINT32(core.rxbuf_min_shift, E1000EState),
>>>         VMSTATE_UINT8(core.rx_desc_len, E1000EState),
>>>         VMSTATE_UINT32_ARRAY(core.rxbuf_sizes, E1000EState,
>>> -- 
>>> 2.1.0
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>