From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47925)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bFzyT-0000VF-CB
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 04:26:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bFzyO-0007oa-AT
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 04:26:57 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33977)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bFzyO-0007oU-4w
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 04:26:52 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id C62C26317F
	for <qemu-devel@nongnu.org>; Thu, 23 Jun 2016 08:26:51 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <1466437983-27133-1-git-send-email-ehabkost@redhat.com>
	<1466437983-27133-11-git-send-email-ehabkost@redhat.com>
Date: Thu, 23 Jun 2016 10:26:49 +0200
In-Reply-To: <1466437983-27133-11-git-send-email-ehabkost@redhat.com> (Eduardo
	Habkost's message of "Mon, 20 Jun 2016 12:53:03 -0300")
Message-ID: <87a8ic5n06.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v2 10/10] machine: Skip global registration
 for non-existing classes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>

Eduardo Habkost <ehabkost@redhat.com> writes:

> MachineClass::compat_props may point to class names that are not
> compiled into the QEMU binary. Skip registering those as global
> properties. This will allow the qdev global property code to
> implement stricter checks on the global property values in the
> future.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Not sure what those stricter checks might be, but that's okay.

Doesn't this suppress detection of programming errors?  Say I fat-finger
a device name in my machine type's global properties.  Before this
patch, I get an error (a nice one since PATCH 06).