From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFzHp-0000bn-Ub for qemu-devel@nongnu.org; Thu, 23 Jun 2016 03:42:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFzHi-00048g-Pa for qemu-devel@nongnu.org; Thu, 23 Jun 2016 03:42:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59820) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFzHi-00048a-JW for qemu-devel@nongnu.org; Thu, 23 Jun 2016 03:42:46 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1E13B7264F for ; Thu, 23 Jun 2016 07:42:46 +0000 (UTC) From: Markus Armbruster References: <1466437983-27133-1-git-send-email-ehabkost@redhat.com> <1466437983-27133-3-git-send-email-ehabkost@redhat.com> Date: Thu, 23 Jun 2016 09:42:44 +0200 In-Reply-To: <1466437983-27133-3-git-send-email-ehabkost@redhat.com> (Eduardo Habkost's message of "Mon, 20 Jun 2016 12:52:55 -0300") Message-ID: <87a8ic73m3.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 02/10] qdev: Eliminate qemu_add_globals() function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Marcel Apfelbaum , Paolo Bonzini , Igor Mammedov Eduardo Habkost writes: > The function is just a helper to handle the -global options, it > can stay in vl.c like most qemu_opts_foreach() calls. > > Reviewed-by: Igor Mammedov > Signed-off-by: Eduardo Habkost > --- > hw/core/qdev-properties-system.c | 21 +-------------------- > include/qemu/config-file.h | 1 - > vl.c | 16 +++++++++++++++- > 3 files changed, 16 insertions(+), 22 deletions(-) > > diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c > index 891219a..cf7139d 100644 > --- a/hw/core/qdev-properties-system.c > +++ b/hw/core/qdev-properties-system.c > @@ -1,5 +1,5 @@ > /* > - * qdev property parsing and global properties > + * qdev property parsing > * (parts specific for qemu-system-*) > * > * This file is based on code from hw/qdev-properties.c from Extra points for remembering to update the file comment. Reviewed-by: Markus Armbruster [...]