From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932105AbcFTIQU (ORCPT ); Mon, 20 Jun 2016 04:16:20 -0400 Received: from mga02.intel.com ([134.134.136.20]:10462 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751634AbcFTIQD (ORCPT ); Mon, 20 Jun 2016 04:16:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,497,1459839600"; d="asc'?scan'208";a="991216469" From: Felipe Balbi To: Baolin Wang , gregkh@linuxfoundation.org Cc: broonie@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, baolin.wang@linaro.org Subject: Re: [PATCH] usb: dwc3: gadget: Add the suspend state checking when stopping gadget In-Reply-To: References: User-Agent: Notmuch/0.22+11~g124a67e (http://notmuchmail.org) Emacs/25.0.93.2 (x86_64-pc-linux-gnu) Date: Mon, 20 Jun 2016 11:15:11 +0300 Message-ID: <87a8igxomo.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Baolin Wang writes: > It will be crash to stop gadget when the dwc3 device had been into suspend > state, thus we need to check if the dwc3 device had been into suspend sta= te > when UDC try to stop gadget. > > By the way I have rebased on your 'testing/next' branch. do you really want this note to be in commit log? Seems like this should be after tearline below. > > Signed-off-by: Baolin Wang > --- > drivers/usb/dwc3/gadget.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index 6dde376..351769e 100644 > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@ -1791,6 +1791,9 @@ err0: >=20=20 > static void __dwc3_gadget_stop(struct dwc3 *dwc) > { > + if (pm_runtime_suspended(dwc->dev)) > + return; > + > dwc3_gadget_disable_irq(dwc); > __dwc3_gadget_ep_disable(dwc->eps[0]); > __dwc3_gadget_ep_disable(dwc->eps[1]); > --=20 > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXZ6YPAAoJEIaOsuA1yqREvv8P/RGTRU2ptZ8Tas0KDDtqDRnl whUwGd11F3JIV7puCWYxXAxHJVEhwxoRRg/L3XlLlxdDnQcyCZzPzPilCCUTP13j zeQRNZ9vzpzg20qjKwH+RcR/NpyxgUK4OEi8nEykYHBQ/VHEfVtuaGeCGBa2H4TO tojp84IGgm80N2krqjs6wDa+alVQ8k9kkztlhBzQsJpkaPZTaMN9XPa9z9XE3Rz8 G1U8mZSRiqF1hC8yqMRR2jgLCZCOljyV9y23EvX7UzjFppiB0zkGdbsmuT/yy0mG DZqhx9L9NnO2lituHFRE3vHs/2/Q4DYleW7Pb0puSDpVXuRg5mA1ZIHcw7FO6PMb MC3QkyzfNQ/9Pyk5kTW2ECeV4BhSIXW9WzOKY3gjoq5sIx0/gCmdEak0RcWmJ7Vb v5Y6bA22O069+asPKt/yYTykSZn+EUGfRkCuQHPuLgayB1bCinUcd2+rE7voPqOE a9u0eA2oi21Dr0zPfe7bMCzcU0pS0m7lvnBFsr7K0ktlYD4/EOmatOT5+7k0vtPo DTBRZVHp6H3jY9Jj/pnUtlGkYNUAoZjTcXogKzUg0qBRp7Va4OckEKOZe26WkMFs 2HmFrNlf7lFXrmEezrjBU93rtZi/tLSnOJ2uoj4lQwI5oVl6c8InbUjb+EY5Z1N8 fiPjG9Ts2K2/CinSTWXO =w3Mv -----END PGP SIGNATURE----- --=-=-=--