From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH v4 01/28] qapi: Rename (one) qjson.h to qobject-json.h Date: Wed, 01 Jun 2016 17:09:11 +0200 Message-ID: <87a8j5q73c.fsf@dusky.pond.sub.org> References: <1463632874-28559-1-git-send-email-eblake@redhat.com> <1463632874-28559-2-git-send-email-eblake@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Cc: qemu-devel@nongnu.org, Kevin Wolf , Alexander Graf , "open list\:Block layer core" , Alberto Garcia , Michael Roth , Chrysostomos Nanakos , "Michael S. Tsirkin" , Jeff Cody , Max Reitz , Christian Borntraeger , Gerd Hoffmann , "open list\:Overall" , Cornelia Huck , Paolo Bonzini , Luiz Capitulino , Jason Wang , Richard Henderson To: Eric Blake Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56278 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545AbcFAPJR (ORCPT ); Wed, 1 Jun 2016 11:09:17 -0400 In-Reply-To: <1463632874-28559-2-git-send-email-eblake@redhat.com> (Eric Blake's message of "Wed, 18 May 2016 22:40:47 -0600") Sender: kvm-owner@vger.kernel.org List-ID: Eric Blake writes: > We have two different JSON visitors in the tree; and having both > named 'qjson.h' can cause include confusion. Rename the qapi > version. Commit 17b74b9 moved the other one to migration/. If you still want to rename this one, you'll need to update the commit message. > Why did I pick that one? A later patch plans on deleting the > top-level qjson.c once we have a native JSON output visitor; we David objected to that in review of v3. We agreed to disagree, and let migration keep its own (incomplete) JSON visitor. That's why I moved it to migration/. > could have renamed that one for less overall churn. On the other > hand, all of the QObject subtypes have their own qFOO.c file, but > qjson.c makes it sound like we have a QTYPE_JSON subclass of > QObject; the new name of qobject-json makes it obvious that the > file is used for conversions between QObject and JSON, and not a > QObject subtype. > > Kill trailing whitespace in the renamed tests/check-qobject-json.c > to keep checkpatch.pl happy. > > Signed-off-by: Eric Blake > Reviewed-by: Paolo Bonzini From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b87lv-0006hS-SH for qemu-devel@nongnu.org; Wed, 01 Jun 2016 11:09:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b87lr-0003PW-RB for qemu-devel@nongnu.org; Wed, 01 Jun 2016 11:09:27 -0400 From: Markus Armbruster References: <1463632874-28559-1-git-send-email-eblake@redhat.com> <1463632874-28559-2-git-send-email-eblake@redhat.com> Date: Wed, 01 Jun 2016 17:09:11 +0200 In-Reply-To: <1463632874-28559-2-git-send-email-eblake@redhat.com> (Eric Blake's message of "Wed, 18 May 2016 22:40:47 -0600") Message-ID: <87a8j5q73c.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v4 01/28] qapi: Rename (one) qjson.h to qobject-json.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Kevin Wolf , Alexander Graf , "open list:Block layer core" , Alberto Garcia , Michael Roth , Chrysostomos Nanakos , "Michael S. Tsirkin" , Jeff Cody , Max Reitz , Christian Borntraeger , Gerd Hoffmann , "open list:Overall" , Cornelia Huck , Paolo Bonzini , Luiz Capitulino , Jason Wang , Richard Henderson Eric Blake writes: > We have two different JSON visitors in the tree; and having both > named 'qjson.h' can cause include confusion. Rename the qapi > version. Commit 17b74b9 moved the other one to migration/. If you still want to rename this one, you'll need to update the commit message. > Why did I pick that one? A later patch plans on deleting the > top-level qjson.c once we have a native JSON output visitor; we David objected to that in review of v3. We agreed to disagree, and let migration keep its own (incomplete) JSON visitor. That's why I moved it to migration/. > could have renamed that one for less overall churn. On the other > hand, all of the QObject subtypes have their own qFOO.c file, but > qjson.c makes it sound like we have a QTYPE_JSON subclass of > QObject; the new name of qobject-json makes it obvious that the > file is used for conversions between QObject and JSON, and not a > QObject subtype. > > Kill trailing whitespace in the renamed tests/check-qobject-json.c > to keep checkpatch.pl happy. > > Signed-off-by: Eric Blake > Reviewed-by: Paolo Bonzini