From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abTrl-0007P1-QI for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:04:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abTrf-0002CK-Uf for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:04:33 -0500 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:35515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abTrf-0002C9-LQ for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:04:27 -0500 Received: by mail-wm0-x234.google.com with SMTP id l68so132723614wml.0 for ; Thu, 03 Mar 2016 06:04:27 -0800 (PST) References: <1456156787-17509-1-git-send-email-alex.bennee@linaro.org> <1456156787-17509-6-git-send-email-alex.bennee@linaro.org> <56D0B4CE.3060204@twiddle.net> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <56D0B4CE.3060204@twiddle.net> Date: Thu, 03 Mar 2016 14:04:24 +0000 Message-ID: <87a8mflkt3.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v7 5/9] qemu-log: new option -dfilter to limit output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: pbonzini@redhat.com, crosthwaitepeter@gmail.com, qemu-devel@nongnu.org, aurelien@aurel32.net, dgilbert@redhat.com Richard Henderson writes: > On 02/22/2016 07:59 AM, Alex Bennée wrote: >> + qemu_set_dfilter_ranges("0x1000+0x100"); >> + >> + g_assert_false(qemu_log_in_addr_range(0xfff)); >> + g_assert(qemu_log_in_addr_range(0x1000)); >> + g_assert(qemu_log_in_addr_range(0x1100)); > > This is exactly what I was talking about wrt off-by-one error in my first > review -- 0x100 bytes, including 0x1000, finishes at 0x10ff. > > This third test should fail. OK so should 0x100+0x0 fail as it makes no sense, 0 bytes from 0x100 start? > > > r~ -- Alex Bennée