From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ab3Qf-0002nO-5j for qemu-devel@nongnu.org; Wed, 02 Mar 2016 04:50:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ab3Qb-0006Ig-23 for qemu-devel@nongnu.org; Wed, 02 Mar 2016 04:50:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ab3Qa-0006IQ-Mi for qemu-devel@nongnu.org; Wed, 02 Mar 2016 04:50:44 -0500 From: Markus Armbruster References: <1456771254-17511-1-git-send-email-armbru@redhat.com> <1456771254-17511-9-git-send-email-armbru@redhat.com> <56D5B960.3080402@redhat.com> Date: Wed, 02 Mar 2016 10:50:41 +0100 In-Reply-To: <56D5B960.3080402@redhat.com> (Eric Blake's message of "Tue, 1 Mar 2016 08:46:40 -0700") Message-ID: <87a8mhp5se.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 08/38] ivshmem: Rewrite specification document List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: claudio.fontana@huawei.com, qemu-devel@nongnu.org, david.marchand@6wind.com, mlureau@redhat.com, pbonzini@redhat.com, cam@cs.ualberta.ca Eric Blake writes: > On 02/29/2016 11:40 AM, Markus Armbruster wrote: >> This started as an attempt to update ivshmem_device_spec.txt for >> clarity, accuracy and completeness while working on its code, and >> quickly became a full rewrite. Since the diff would be useless >> anyway, I'm using the opportunity to rename the file to >> ivshmem-spec.txt. >> >> I tried hard to ensure the new text contradicts neither the old text >> nor the code. If the new text contradicts the old text but not the >> code, it's probably a bug in the old text. If the new text >> contradicts both, its probably a bug in the new text. >> >> Signed-off-by: Markus Armbruster >> --- > >> +If the server terminates without sending disconnect notifications for >> +its connected clients, the clients can elect to continue. They can >> +communicate with each other normally, but won't receive disconnect >> +notification on disconnect, and no new clients can connect. There is >> +no way for the clients to connect to a restarted the server. The > > s/the server/server/ Will fix, thanks! >> +device is not capable to tell guest software whether the server is >> +still up. > > Wow - lots of shortcomings in the server protocol. Food for thought for > future improvements, but I'm happy with your approach of just > documenting pitfalls for now. Best we can do for 2.6 anyway :) >> + >> +Known bugs: >> + >> +* The protocol changed incompatibly in QEMU 2.5. Before, messages >> + were native endian long, and there was no version number. >> + >> +* The protocol is poorly designed.