Re: [PATCH skeleton v2 1/2] Implement new LED driver

[Stewart Smith <stewart@linux.vnet.ibm.com>]

OpenBMC Patches <openbmc-patches@stwcx.xyz> writes:
> From: Adriana Kobylak <anoo@us.ibm.com>
>
> Verification for the new LED driver is completed so time to replace the
> previous gpio implementation with the new one. This entails
> replacing the led_controller file with the led_controller_new file,
> updating the dbus interface name so that it is the same as the previous
> one, and updating the code with the new led names.
> ---
>  Makefile                     |   7 +-
>  bin/Barreleye.py             |  12 +-
>  bin/Palmetto.py              |   6 +-
>  bin/chassis_control.py       |   2 +-
>  bin/obmcutil                 |   2 +-
>  objects/led_controller.c     | 617 ++++++++++++++++++++++++++++++++-----------
>  objects/led_controller_new.c | 488 ----------------------------------
>  7 files changed, 470 insertions(+), 664 deletions(-)
>  delete mode 100755 objects/led_controller_new.c
>
> diff --git a/Makefile b/Makefile
> index 65787ff..49600ba 100755
> --- a/Makefile
> +++ b/Makefile
> @@ -36,11 +36,8 @@ libopenbmc_intf: openbmc_intf.o
>  power_control: power_control_obj.o gpio.o object_mapper.o libopenbmc_intf
>  	$(CC) -o bin/$@.exe obj/gpio.o obj/power_control_obj.o obj/object_mapper.o $(LDFLAGS) $(LIBS)
>  
> -led_controller: led_controller.o gpio.o object_mapper.o libopenbmc_intf
> -	$(CC) -o bin/$@.exe obj/gpio.o obj/led_controller.o obj/object_mapper.o $(LDFLAGS) $(LIBS)
> -
> -led_controller_new: led_controller_new.o
> -	$(CC) -o bin/$@.exe obj/led_controller_new.o $(LDFLAGS) $(LIBS) -lsystemd
> +led_controller: led_controller.o
> +	$(CC) -o bin/$@.exe obj/led_controller.o $(LDFLAGS) $(LIBS)
> -lsystemd

.exe ? Really?

-- 
Stewart Smith
OPAL Architect, IBM.