From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: module: preserve Elf information for livepatch modules Date: Fri, 15 Jan 2016 06:58:08 +1030 Message-ID: <87a8o76h47.fsf@rustcorp.com.au> References: <1452281304-28618-1-git-send-email-jeyu@redhat.com> <1452281304-28618-3-git-send-email-jeyu@redhat.com> <87oacshpqn.fsf@rustcorp.com.au> <20160114044718.GC980@packer-debian-8-amd64.digitalocean.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20160114044718.GC980-N0bYjD2NfQ6k4hzjq3hgyGTy53QMssKEsp+A89P3RPuQWHG76I6BsA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jessica Yu Cc: Josh Poimboeuf , Seth Jennings , Jiri Kosina , Vojtech Pavlik , Jonathan Corbet , Miroslav Benes , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, live-patching-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org Jessica Yu writes: > +++ Rusty Russell [11/01/16 11:55 +1030]: >>This comment is a bit misleading: it's actually pointing into the >>temporary module copy, which will be discarded. The init section is >>slightly different... > > Ah, perhaps I'm misunderstanding something.. > > Since copy_module_elf() is called after move_module(), my > understanding is that all the section sh_addr's should be pointing > to either module core memory or module init memory (instead of the > initial temporary copy of the module in info->hdr). You're absolutely correct; I'd forgotten that particular kallsyms twist. Sorry for the noise! Rusty. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754722AbcANU2n (ORCPT ); Thu, 14 Jan 2016 15:28:43 -0500 Received: from ozlabs.org ([103.22.144.67]:36772 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752758AbcANU2l (ORCPT ); Thu, 14 Jan 2016 15:28:41 -0500 From: Rusty Russell To: Jessica Yu Cc: Josh Poimboeuf , Seth Jennings , Jiri Kosina , Vojtech Pavlik , Jonathan Corbet , Miroslav Benes , linux-api@vger.kernel.org, live-patching@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: module: preserve Elf information for livepatch modules In-Reply-To: <20160114044718.GC980@packer-debian-8-amd64.digitalocean.com> References: <1452281304-28618-1-git-send-email-jeyu@redhat.com> <1452281304-28618-3-git-send-email-jeyu@redhat.com> <87oacshpqn.fsf@rustcorp.com.au> <20160114044718.GC980@packer-debian-8-amd64.digitalocean.com> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 15 Jan 2016 06:58:08 +1030 Message-ID: <87a8o76h47.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jessica Yu writes: > +++ Rusty Russell [11/01/16 11:55 +1030]: >>This comment is a bit misleading: it's actually pointing into the >>temporary module copy, which will be discarded. The init section is >>slightly different... > > Ah, perhaps I'm misunderstanding something.. > > Since copy_module_elf() is called after move_module(), my > understanding is that all the section sh_addr's should be pointing > to either module core memory or module init memory (instead of the > initial temporary copy of the module in info->hdr). You're absolutely correct; I'd forgotten that particular kallsyms twist. Sorry for the noise! Rusty.