Re: [PATCH] drm/i915: Fix crtc_y assignment in intel_find_initial_plane_obj()

From: Jani Nikula <jani.nikula@linux.intel.com>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix crtc_y assignment in	intel_find_initial_plane_obj()
Date: Fri, 13 Nov 2015 19:36:08 +0200	[thread overview]
Message-ID: <87a8qhiyyf.fsf@intel.com> (raw)
In-Reply-To: <1447434973-12369-1-git-send-email-ville.syrjala@linux.intel.com>

On Fri, 13 Nov 2015, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Let's set crtc_y to 0 instead of setting src_y twice.
>
> Multiple assignments in one statement is a good way to hide bugs.
> Please don't do that.
>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Fixes: be5651f2d581 ("drm/i915: Update missing properties in find_initial_plane_obj")

Cc: stable@vger.kernel.org # v4.3+

right?

> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index d7c8a0f..e3db46d 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -2640,11 +2640,13 @@ intel_find_initial_plane_obj(struct intel_crtc *intel_crtc,
>  	return;
>  
>  valid_fb:
> -	plane_state->src_x = plane_state->src_y = 0;
> +	plane_state->src_x = 0;
> +	plane_state->src_y = 0;
>  	plane_state->src_w = fb->width << 16;
>  	plane_state->src_h = fb->height << 16;
>  
> -	plane_state->crtc_x = plane_state->src_y = 0;
> +	plane_state->crtc_x = 0;
> +	plane_state->crtc_y = 0;
>  	plane_state->crtc_w = fb->width;
>  	plane_state->crtc_h = fb->height;

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx