From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52861)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1Zn7CJ-00024E-GF
	for qemu-devel@nongnu.org; Fri, 16 Oct 2015 11:45:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1Zn7CE-0003bk-Up
	for qemu-devel@nongnu.org; Fri, 16 Oct 2015 11:45:35 -0400
Received: from roura.ac.upc.es ([147.83.33.10]:56533)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1Zn7CE-0003bV-J3
	for qemu-devel@nongnu.org; Fri, 16 Oct 2015 11:45:30 -0400
From: =?utf-8?Q?Llu=C3=ADs_Vilanova?= <vilanova@ac.upc.edu>
References: <20151013171020.21325.27626.stgit@localhost>
	<20151013171032.21325.61781.stgit@localhost>
	<20151016091612.GF7432@stefanha-thinkpad.redhat.com>
Date: Fri, 16 Oct 2015 17:45:28 +0200
In-Reply-To: <20151016091612.GF7432@stefanha-thinkpad.redhat.com> (Stefan
	Hajnoczi's message of "Fri, 16 Oct 2015 11:16:12 +0200")
Message-ID: <87a8rizujr.fsf@fimbulvetr.bsc.es>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCHv12/8] trace: Add 'vcpu' event property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org

Stefan Hajnoczi writes:

> On Tue, Oct 13, 2015 at 07:10:33PM +0200, Llu=C3=ADs Vilanova wrote:
>> diff --git a/scripts/tracetool/format/h.py b/scripts/tracetool/format/h.=
py
>> index 9b39430..4bdb48f 100644
>> --- a/scripts/tracetool/format/h.py
>> +++ b/scripts/tracetool/format/h.py
>> @@ -6,7 +6,7 @@ trace/generated-tracers.h
>> """
>>=20
>> __author__     =3D "Llu=C3=ADs Vilanova <vilanova@ac.upc.edu>"
>> -__copyright__ =3D "Copyright 2012-2014, Llu=C3=ADs Vilanova <vilanova@a=
c.upc.edu>"
>> +__copyright__  =3D "Copyright 2012-2015, Llu=C3=ADs Vilanova <vilanova@=
ac.upc.edu>"
>> __license__    =3D "GPL version 2 or (at your option) any later version"
>>=20
>> __maintainer__ =3D "Stefan Hajnoczi"
>> @@ -23,6 +23,8 @@ def generate(events, backend):
>> '#define TRACE__GENERATED_TRACERS_H',
>> '',
>> '#include "qemu-common.h"',
>> +        '',
>> +        'typedef struct CPUState CPUState;',

> Here...

>> diff --git a/scripts/tracetool/format/ust_events_c.py b/scripts/tracetoo=
l/format/ust_events_c.py
>> index bc97093..92064f0 100644
>> --- a/scripts/tracetool/format/ust_events_c.py
>> +++ b/scripts/tracetool/format/ust_events_c.py
>> @@ -6,7 +6,7 @@ trace/generated-ust.c
>> """
>>=20
>> __author__     =3D "Mohamad Gebai <mohamad.gebai@polymtl.ca>"
>> -__copyright__  =3D "Copyright 2012, Mohamad Gebai <mohamad.gebai@polymt=
l.ca>"
>> +__copyright__  =3D "Copyright 2012, 2015, Mohamad Gebai <mohamad.gebai@=
polymtl.ca>"
>> __license__    =3D "GPL version 2 or (at your option) any later version"
>>=20
>> __maintainer__ =3D "Stefan Hajnoczi"
>> @@ -30,4 +30,6 @@ def generate(events, backend):
>> ' */',
>> '#pragma GCC diagnostic ignored "-Wredundant-decls"',
>> '',
>> +        'typedef struct CPUState CPUState;',
>> +        '',
>> '#include "generated-ust-provider.h"')

> ...and here is okay but please generate a comment so it's clear why this
> needs to be defined.

Will do.

Thanks,
  Lluis

--=20
"And it's much the same thing with knowledge, for whenever you learn
something new, the whole world becomes that much richer."
-- The Princess of Pure Reason, as told by Norton Juster in The Phantom
Tollbooth