From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754081AbbIHHbp (ORCPT ); Tue, 8 Sep 2015 03:31:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41431 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753922AbbIHHbm (ORCPT ); Tue, 8 Sep 2015 03:31:42 -0400 From: Vitaly Kuznetsov To: Ingo Molnar Cc: Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Greg Kroah-Hartman , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hyperv: fix build if KEXEC not enabled References: <20150907102222.27d0477b@urahara> <20150908071458.GA5291@gmail.com> Date: Tue, 08 Sep 2015 09:31:37 +0200 In-Reply-To: <20150908071458.GA5291@gmail.com> (Ingo Molnar's message of "Tue, 8 Sep 2015 09:14:58 +0200") Message-ID: <87a8sxbc4m.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar writes: > * Stephen Hemminger wrote: > >> Fixes regression 4.3 mergw window in my config >> where hyperv is enable but CONFIG_KEXEC not enabled. >> >> arch/x86/kernel/cpu/mshyperv.c:112: undefined reference to `native_machine_crash_shutdown' >> >> Introduced by: >> commit b4370df2b1f5158de028e167974263c5757b34a6 >> Author: Vitaly Kuznetsov >> Date: Sat Aug 1 16:08:09 2015 -0700 >> >> Drivers: hv: vmbus: add special crash handler >> >> >> Signed-off-by: Stephen Hemminger >> >> >> --- a/arch/x86/kernel/cpu/mshyperv.c 2015-09-07 10:11:24.994885115 -0700 >> +++ b/arch/x86/kernel/cpu/mshyperv.c 2015-09-07 10:14:20.995698615 -0700 >> @@ -109,7 +109,9 @@ static void hv_machine_crash_shutdown(st >> { >> if (hv_crash_handler) >> hv_crash_handler(regs); >> +#ifdef CONFIG_KEXEC >> native_machine_crash_shutdown(regs); >> +#endif > > I think there's another related bug as well: > > machine_ops.crash_shutdown = hv_machine_crash_shutdown; > > that should be #ifdef CONFIG_KEXEC as well AFAICS. > Why? crash_shutdown is defined in machine_ops unconditionally, I don't see why we _need_ #ifdef here (and btw Greg insisted on removing them). > These bugs came upstream via the driver tree: > > b4370df2b1f5 ("Drivers: hv: vmbus: add special crash handler") > 2517281d63a2 ("Drivers: hv: vmbus: add special kexec handler") > > Thanks, > > Ingo -- Vitaly