All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/bash: indicate getcwd is malloc-supported
Date: Fri, 04 Sep 2015 16:45:57 +0200	[thread overview]
Message-ID: <87a8t2mee2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1441292409-5264-1-git-send-email-james.knight@rockwellcollins.com> (James Knight's message of "Thu, 3 Sep 2015 11:00:09 -0400")

>>>>> "James" == James Knight <james.knight@rockwellcollins.com> writes:

 > When Bash attempts to find the current working directory, it uses a C
 > library call `getcwd` to resolve it. When cross-compiling, the
 > configuration process cannot determine if the target system's C library
 > can support an "unfixed" path length. Therefore, Bash will fallback to a
 > size of `PATH_MAX` for determining the current working directory. When
 > using OverlayFS (and possible other file systems), this becomes an issue
 > since file paths can commonly exceed standard `PATH_MAX` length. This
 > typically results in the following error appearing:

 >    error retrieving current directory: [...]

 > Common C library `getcwd` calls can default to a higher limit (usually
 > the system's page size). The current configurable C libraries (as of at
 > least 2015.08) support a zero (0) size buffer length. Most use the
 > system's page size; musl, being an exception, which defaults to
 > `PATH_MAX` (as Bash was doing). Since these C libraries support
 > allocating buffer space with a zero (0) provided size, the following
 > configuration change allows Bash to support getting a larger-length'ed
 > working directory on target's that support it.

 > Signed-off-by: James Knight <james.knight@rockwellcollins.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2015-09-04 14:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-03 15:00 [Buildroot] [PATCH 1/1] package/bash: indicate getcwd is malloc-supported James Knight
2015-09-03 21:02 ` Arnout Vandecappelle
2015-09-04 14:45 ` Peter Korsgaard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-08-30 12:20 James Knight
2015-08-30 10:46 James Knight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8t2mee2.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.