From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNxFh-0002zg-LB for qemu-devel@nongnu.org; Sat, 08 Aug 2015 02:05:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZNxFc-0007Bh-M6 for qemu-devel@nongnu.org; Sat, 08 Aug 2015 02:05:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNxFc-00078X-GS for qemu-devel@nongnu.org; Sat, 08 Aug 2015 02:05:00 -0400 From: Markus Armbruster References: Date: Sat, 08 Aug 2015 08:04:56 +0200 In-Reply-To: (Programmingkid's message of "Thu, 6 Aug 2015 09:10:18 -0400") Message-ID: <87a8u29uyf.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2] qemu-doc.texi: Add usb sound card info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Programmingkid Cc: John Snow , qemu-devel qemu-devel , Gerd Hoffmann Copying USB maintainer... Programmingkid writes: > Add info on usb sound card to qemu documentation. > > Signed-off-by: John Arbuckle > > --- > Changed 'thru' to 'through' > > qemu-doc.texi | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/qemu-doc.texi b/qemu-doc.texi > index 0125bc7..9a8f353 100644 > --- a/qemu-doc.texi > +++ b/qemu-doc.texi > @@ -1328,7 +1328,8 @@ as necessary to connect multiple USB devices. > @subsection Connecting USB devices > > USB devices can be connected with the @option{-usbdevice} commandline option > -or the @code{usb_add} monitor command. Available devices are: > +or the @code{usb_add} monitor command. Note: some devices may only work if > +added like this: -usb -device . Available devices are: I'm afraid "may only work" is a bit misleading. All of them work with -device. Old ones are also supported by -usbdevice for backward compatibility. The whole section should be rewritten to point to -device instead of legacy -usbdevice, but that's no reason to hold up your patch. I'd just drop this hunk for now. Suboptimal, but I can't think of a better way short of doing the rewrite. Perhaps Gerd can. > +or the @code{usb_add} monitor command. Note: some devices may only work if > +added like this: -usb -device . Available devices are: > @table @code > @item mouse > @@ -1381,6 +1382,8 @@ usage: > @example > qemu-system-i386 [...OPTIONS...] -usbdevice bt:hci,vlan=3 -bt device:keyboard,vlan=3 > @end example > +@item usb-audio > +USB sound card. Can only be used if added through the command-line like this: -usb -device usb-audio > @end table > > @node host_usb_devices Long line. Could perhaps be fixed on commit. With the first hunk dropped and the line wrapped: Reviewed-by: Markus Armbruster