From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1waw-0007Sf-El for qemu-devel@nongnu.org; Mon, 08 Jun 2015 08:56:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1wat-0004Zp-0T for qemu-devel@nongnu.org; Mon, 08 Jun 2015 08:56:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1was-0004Zi-NN for qemu-devel@nongnu.org; Mon, 08 Jun 2015 08:55:58 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 03E48BC918 for ; Mon, 8 Jun 2015 12:55:57 +0000 (UTC) From: Markus Armbruster References: <557217CF.4090907@redhat.com> <55721905.2040307@redhat.com> <55721A5A.9080304@redhat.com> Date: Mon, 08 Jun 2015 14:55:55 +0200 In-Reply-To: <55721A5A.9080304@redhat.com> (Laszlo Ersek's message of "Fri, 05 Jun 2015 23:53:30 +0200") Message-ID: <87a8wagy04.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] qemu commit 65207c59 broke libvirt's capability retrieval (apparently) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: libvir-list@redhat.com, qemu devel list Laszlo Ersek writes: > On 06/05/15 23:47, Eric Blake wrote: >> On 06/05/2015 03:42 PM, Laszlo Ersek wrote: >> >>> I found this qemu commit, ie. >>> >>> commit 65207c59d99f2260c5f1d3b9c491146616a522aa >>> Author: Markus Armbruster >>> Date: Thu Mar 5 14:35:26 2015 +0100 >>> >>> monitor: Drop broken, unused asynchronous command interface >>> >>> with bisection. Unfortunately, the bisection was extremely painful, >>> because between a working version and today's pull, part of the >>> qemu history was uncompileable. It was ultimately fixed with >> >>> Which tells me that it's not individual capabilities that are >>> broken by qemu 65207c59, but the entire libvirt capability >>> retrieval. Apparently libvirt is one user of that async monitor >>> interface. (The message on commit 65207c59 itself mentions >>> "qmp_capabilities".) >> >> Libvirt doesn't use async capabilities, so much as Markus accidentally >> broke the QMP protocol by completely ditching support for the "id" >> member that libvirt uses on every synchronous QMP command. Several >> threads already exist on the matter: >> >> https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01806.html >> https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01488.html >> > > Fantastic, I was wondering how I could remedy this (without having to > rebase my work in progress onto 65207c59^). Your second link seems to > have a fix I can apply locally, temporarily. (Hm, well, your first link > does too, just with different comments, as you said.) > > Many thanks! Fixed in current master: commit 779cec4. Sorry for the inconvenience!