From: Kalle Valo <kvalo@codeaurora.org>
To: Vladimir Kondratiev <QCA_vkondrat@QCA.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, wil6210@qca.qualcomm.com
Subject: Re: [PATCH] wil6210: fix format specifier for dma_addr_t
Date: Sat, 09 May 2015 15:10:31 +0300 [thread overview]
Message-ID: <87a8xene88.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1430840528-14998-1-git-send-email-qca_vkondrat@qca.qualcomm.com> (Vladimir Kondratiev's message of "Tue, 5 May 2015 18:42:08 +0300")
Vladimir Kondratiev <QCA_vkondrat@QCA.qualcomm.com> writes:
> Fix format specifier used for dma_addr_t, namely use %pad
> Debug print virtual address for the same buffer as well.
>
> It can be applied as:
> fixup! wil6210: Add pmc debug mechanism memory management
>
> Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
The right format for specifying the commit which this patch fixes is:
Fixes: dc16427bbe65 ("wil6210: Add pmc debug mechanism memory management")
See Documentatin/SubmittingPatches for more info.
But I see new warnings with this patch:
drivers/net/wireless/ath/wil6210/pmc.c:94:243: warning: format '%p' expects argument of type 'void *', but argument 6 has type 'dma_addr_t' [-Wformat]
drivers/net/wireless/ath/wil6210/pmc.c:94:478: warning: format '%p' expects argument of type 'void *', but argument 5 has type 'dma_addr_t' [-Wformat]
--
Kalle Valo
prev parent reply other threads:[~2015-05-09 12:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 22:11 [PATCH v3 0/7] wil6210 patches Vladimir Kondratiev
2015-05-04 22:11 ` [PATCH v3 1/7] wil6210: increase timeout for the "echo" command Vladimir Kondratiev
2015-05-04 22:11 ` [PATCH v3 2/7] wil6210: update Rx descriptor fields Vladimir Kondratiev
2015-05-04 22:11 ` [PATCH v3 3/7] wil6210: fix boot loader "ready" indication Vladimir Kondratiev
2015-05-04 22:11 ` [PATCH v3 4/7] wil6210: fix for probe_resp IE's Vladimir Kondratiev
2015-05-04 22:11 ` [PATCH v3 5/7] wil6210: Add pmc debug mechanism memory management Vladimir Kondratiev
2015-05-04 22:11 ` [PATCH v3 6/7] wil6210: broadcast for secure link Vladimir Kondratiev
2015-05-04 22:11 ` [PATCH v3 7/7] wil6210: support WSC for STA mode Vladimir Kondratiev
2015-05-05 5:33 ` [PATCH v3 0/7] wil6210 patches Kalle Valo
2015-05-05 15:42 ` [PATCH] wil6210: fix format specifier for dma_addr_t Vladimir Kondratiev
2015-05-09 12:10 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8xene88.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=QCA_vkondrat@QCA.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.