All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/5] package/fbv: Switch to giflib
Date: Tue, 27 Jan 2015 16:17:28 +0100	[thread overview]
Message-ID: <87a914z20n.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1422300260-5361-2-git-send-email-bernd.kuhls@t-online.de> (Bernd Kuhls's message of "Mon, 26 Jan 2015 20:24:17 +0100")

>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:

 > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
 > ---
 >  package/fbv/Config.in             |    4 +--
 >  package/fbv/fbv-1.0b-giflib.patch |   69 +++++++++++++++++++++++++++++++++++++
 >  package/fbv/fbv.mk                |   10 +++++-
 >  3 files changed, 80 insertions(+), 3 deletions(-)
 >  create mode 100644 package/fbv/fbv-1.0b-giflib.patch

 > diff --git a/package/fbv/fbv.mk b/package/fbv/fbv.mk
 > index fe24a6f..81881ff 100644
 > --- a/package/fbv/fbv.mk
 > +++ b/package/fbv/fbv.mk
 > @@ -30,7 +30,15 @@ else
 >  FBV_CONFIGURE_OPTS += --without-libjpeg
 >  endif
 >  ifeq ($(BR2_PACKAGE_FBV_GIF),y)
 > -FBV_DEPENDENCIES += libungif
 > +FBV_DEPENDENCIES += giflib
 > +define FBV_CONFIGURE_LIBUNGIF_IS_NOW_GIFLIB
 > +	$(SED) 's|-lungif|-lgif|' $(@D)/configure
 > +endef
 > +FBV_PRE_CONFIGURE_HOOKS += FBV_CONFIGURE_LIBUNGIF_IS_NOW_GIFLIB
 > +define FBV_MAKE_LIBUNGIF_IS_NOW_GIFLIB
 > +	$(SED) 's|-lungif|-lgif|' $(@D)/Make.conf
 > +endef

Why is it needed to patch Make.conf if you already patch configure
(which generates it)?

I would prefer to see the configure changes in the giflib patch
instead. How do the archlinux guys handle it?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2015-01-27 15:17 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 19:24 [Buildroot] [PATCH 1/5] package/giflib: New package Bernd Kuhls
2015-01-26 19:24 ` [Buildroot] [PATCH 2/5] package/fbv: Switch to giflib Bernd Kuhls
2015-01-27 15:17   ` Peter Korsgaard [this message]
2015-01-29 18:56     ` Bernd Kuhls
2015-01-26 19:24 ` [Buildroot] [PATCH 3/5] package/imlib2: " Bernd Kuhls
2015-01-27 15:25   ` Peter Korsgaard
2015-01-29 19:13     ` Bernd Kuhls
2015-03-07 18:09       ` Fabio Porcedda
2015-01-26 19:24 ` [Buildroot] [PATCH 4/5] package/efl/libevas: " Bernd Kuhls
2015-03-07 16:29   ` Fabio Porcedda
2015-03-07 16:32     ` Thomas Petazzoni
2015-03-07 17:01       ` Fabio Porcedda
2015-03-08  7:15         ` Thomas Petazzoni
2015-03-08  7:28           ` Fabio Porcedda
2015-03-08  7:46             ` Thomas Petazzoni
2015-03-08  7:54               ` Fabio Porcedda
2015-03-08  8:03                 ` Thomas Petazzoni
2015-04-04 16:45   ` Thomas Petazzoni
2015-01-26 19:24 ` [Buildroot] [PATCH 5/5] package/libungif: deprecate package Bernd Kuhls
2015-03-07 17:19   ` Fabio Porcedda
2015-04-04 16:46   ` Thomas Petazzoni
2015-04-08 20:33     ` Bernd Kuhls
2015-01-27 15:12 ` [Buildroot] [PATCH 1/5] package/giflib: New package Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a914z20n.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.