From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Ban Haswell from using RCS flips
Date: Mon, 05 Jan 2015 15:32:30 +0200 [thread overview]
Message-ID: <87a91xgxox.fsf@intel.com> (raw)
In-Reply-To: <87k3191toy.fsf@intel.com>
On Tue, 30 Dec 2014, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Sat, 27 Dec 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> Like Ivybridge, we have reports that we get random hangs when flipping
>> with multiple pipes. Extend
>>
>> commit 2a92d5bca1999b69c78f3c3e97b5484985b094b9
>> Author: Chris Wilson <chris@chris-wilson.co.uk>
>> Date: Tue Jul 8 10:40:29 2014 +0100
>>
>> drm/i915: Disable RCS flips on Ivybridge
>>
>> to also apply to Haswell.
>>
>> Reported-by: Scott Tsai <scottt.tw@gmail.com>
>
> From the bug,
>
> Tested-by: Scott Tsai <scottt.tw@gmail.com>
>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87759
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Pushed to drm-intel-fixes with Daniel's IRC r-b and cc: stable (also on
the ivb commit). Thanks for the patch and review.
BR,
Jani.
>> ---
>> drivers/gpu/drm/i915/intel_display.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>> index d01db1b82869..ed2102e62271 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -9703,7 +9703,7 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc,
>> if (obj->tiling_mode != work->old_fb_obj->tiling_mode)
>> /* vlv: DISPLAY_FLIP fails to change tiling */
>> ring = NULL;
>> - } else if (IS_IVYBRIDGE(dev)) {
>> + } else if (IS_IVYBRIDGE(dev) || IS_HASWELL(dev)) {
>> ring = &dev_priv->ring[BCS];
>> } else if (INTEL_INFO(dev)->gen >= 7) {
>> ring = i915_gem_request_get_ring(obj->last_read_req);
>> --
>> 2.1.4
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Jani Nikula, Intel Open Source Technology Center
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-01-05 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-27 9:48 [PATCH] drm/i915: Ban Haswell from using RCS flips Chris Wilson
2014-12-27 13:57 ` shuang.he
2014-12-30 7:29 ` Jani Nikula
2015-01-05 13:32 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a91xgxox.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.