From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Jesse Barnes" <jbarnes@virtuousgeek.org>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: save/restore GMBUS freq across suspend/resume on gen4
Date: Thu, 11 Dec 2014 15:41:18 +0200 [thread overview]
Message-ID: <87a92u8fsx.fsf@intel.com> (raw)
In-Reply-To: <20141210123729.29d182b1@jbarnes-t420>
On Wed, 10 Dec 2014, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On Wed, 10 Dec 2014 22:35:37 +0200
> Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
>
>> On Wed, Dec 10, 2014 at 12:16:05PM -0800, Jesse Barnes wrote:
>> > Should probably just init this in the GMbus code all the time,
>> > based on the cdclk and HPLL like we do on newer platforms. Ville
>> > has code for that in a rework branch, but until then we can fix
>> > this bug fairly easily.
>> >
>> > References: https://bugs.freedesktop.org/show_bug.cgi?id=76301
>> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>>
>> My cdclk extraction code doesn't seem to agree with this register for
>> this particular bug reporter at least. So I think I need to go double
>> check my code. The other options are that GMBUS clock isn't derived
>> from cdclk on that platform, or that the HPLL/cdclk bits in configdb
>> are simply not valid for this particular chipset.
>>
>> In the meantime however, we can at least get some machines working
>> with this patch. I'm not entirely sure which platforms have this
>> register, but IS_GEN4() looks safe enough since my 946GZ has it and
>> the reporter has a G41.
>>
>> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Great, thanks. Jani, can you pick this up? I'll bounce the original
> over to stable@ too.
Pushed to drm-intel-next-fixes, with cc: stable added. Thanks for the
patch and review.
BR,
Jani
>
> Thanks,
> Jesse
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-12-11 13:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 20:16 [PATCH] drm/i915: save/restore GMBUS freq across suspend/resume on gen4 Jesse Barnes
2014-12-10 20:35 ` Ville Syrjälä
2014-12-10 20:37 ` Jesse Barnes
2014-12-11 13:41 ` Jani Nikula [this message]
2014-12-15 9:11 ` Daniel Vetter
2014-12-11 6:38 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a92u8fsx.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.