From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] gpu: drm: i915: intel_dsi_pll.c: Remove unused function Date: Mon, 08 Dec 2014 12:27:15 +0200 Message-ID: <87a92yo2rg.fsf@intel.com> References: <1417992176-20712-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1417992176-20712-1-git-send-email-rickard_strandqvist@spectrumdigital.se> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rickard Strandqvist List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAwOCBEZWMgMjAxNCwgUmlja2FyZCBTdHJhbmRxdmlzdCA8cmlja2FyZF9zdHJhbmRx dmlzdEBzcGVjdHJ1bWRpZ2l0YWwuc2U+IHdyb3RlOgo+IFJlbW92ZSB0aGUgZnVuY3Rpb24gZHNp X3JyX2Zvcm11bGEoKSB0aGF0IGlzIG5vdCB1c2VkIGFueXdoZXJlLgoKUGxlYXNlIGRvbid0LgoK QlIsCkphbmkuCgo+Cj4gVGhpcyB3YXMgcGFydGlhbGx5IGZvdW5kIGJ5IHVzaW5nIGEgc3RhdGlj IGNvZGUgYW5hbHlzaXMgcHJvZ3JhbSBjYWxsZWQgY3BwY2hlY2suCj4KPiBTaWduZWQtb2ZmLWJ5 OiBSaWNrYXJkIFN0cmFuZHF2aXN0IDxyaWNrYXJkX3N0cmFuZHF2aXN0QHNwZWN0cnVtZGlnaXRh bC5zZT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpX3BsbC5jIHwgICA4 MyArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAx IGluc2VydGlvbigrKSwgODIgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHNpX3BsbC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHNpX3BsbC5jCj4gaW5kZXggZmE3YTZjYS4uMjAwODZlOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kc2lfcGxsLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kc2lfcGxsLmMKPiBAQCAtNTAsODggKzUwLDcgQEAgc3RhdGljIGNvbnN0IHUzMiBs ZnNyX2NvbnZlcnRzW10gPSB7Cj4gIAk3MSwgMzUJCQkJCQkJLyogOTEgLSA5MiAqLwo+ICB9Owo+ ICAKPiAtI2lmZGVmIERTSV9DTEtfRlJPTV9SUgo+IC0KPiAtc3RhdGljIHUzMiBkc2lfcnJfZm9y bXVsYShjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSwKPiAtCQkJICBpbnQgcGl4 ZWxfZm9ybWF0LCBpbnQgdmlkZW9fbW9kZV9mb3JtYXQsCj4gLQkJCSAgaW50IGxhbmVfY291bnQs IGJvb2wgZW90cCkKPiAtewo+IC0JdTMyIGJwcDsKPiAtCXUzMiBoYWN0aXZlLCB2YWN0aXZlLCBo ZnAsIGhzeW5jLCBoYnAsIHZmcCwgdnN5bmMsIHZicDsKPiAtCXUzMiBoc3luY19ieXRlcywgaGJw X2J5dGVzLCBoYWN0aXZlX2J5dGVzLCBoZnBfYnl0ZXM7Cj4gLQl1MzIgYnl0ZXNfcGVyX2xpbmUs IGJ5dGVzX3Blcl9mcmFtZTsKPiAtCXUzMiBudW1fZnJhbWVzOwo+IC0JdTMyIGJ5dGVzX3Blcl94 X2ZyYW1lcywgYnl0ZXNfcGVyX3hfZnJhbWVzX3hfbGFuZXM7Cj4gLQl1MzIgZHNpX2JpdF9jbG9j a19oejsKPiAtCXUzMiBkc2lfY2xrOwo+IC0KPiAtCXN3aXRjaCAocGl4ZWxfZm9ybWF0KSB7Cj4g LQlkZWZhdWx0Ogo+IC0JY2FzZSBWSURfTU9ERV9GT1JNQVRfUkdCODg4Ogo+IC0JY2FzZSBWSURf TU9ERV9GT1JNQVRfUkdCNjY2X0xPT1NFOgo+IC0JCWJwcCA9IDI0Owo+IC0JCWJyZWFrOwo+IC0J Y2FzZSBWSURfTU9ERV9GT1JNQVRfUkdCNjY2Ogo+IC0JCWJwcCA9IDE4Owo+IC0JCWJyZWFrOwo+ IC0JY2FzZSBWSURfTU9ERV9GT1JNQVRfUkdCNTY1Ogo+IC0JCWJwcCA9IDE2Owo+IC0JCWJyZWFr Owo+IC0JfQo+IC0KPiAtCWhhY3RpdmUgPSBtb2RlLT5oZGlzcGxheTsKPiAtCXZhY3RpdmUgPSBt b2RlLT52ZGlzcGxheTsKPiAtCWhmcCA9IG1vZGUtPmhzeW5jX3N0YXJ0IC0gbW9kZS0+aGRpc3Bs YXk7Cj4gLQloc3luYyA9IG1vZGUtPmhzeW5jX2VuZCAtIG1vZGUtPmhzeW5jX3N0YXJ0Owo+IC0J aGJwID0gbW9kZS0+aHRvdGFsIC0gbW9kZS0+aHN5bmNfZW5kOwo+IC0KPiAtCXZmcCA9IG1vZGUt PnZzeW5jX3N0YXJ0IC0gbW9kZS0+dmRpc3BsYXk7Cj4gLQl2c3luYyA9IG1vZGUtPnZzeW5jX2Vu ZCAtIG1vZGUtPnZzeW5jX3N0YXJ0Owo+IC0JdmJwID0gbW9kZS0+dnRvdGFsIC0gbW9kZS0+dnN5 bmNfZW5kOwo+IC0KPiAtCWhzeW5jX2J5dGVzID0gRElWX1JPVU5EX1VQKGhzeW5jICogYnBwLCA4 KTsKPiAtCWhicF9ieXRlcyA9IERJVl9ST1VORF9VUChoYnAgKiBicHAsIDgpOwo+IC0JaGFjdGl2 ZV9ieXRlcyA9IERJVl9ST1VORF9VUChoYWN0aXZlICogYnBwLCA4KTsKPiAtCWhmcF9ieXRlcyA9 IERJVl9ST1VORF9VUChoZnAgKiBicHAsIDgpOwo+IC0KPiAtCWJ5dGVzX3Blcl9saW5lID0gRFNJ X0hTU19QQUNLRVRfU0laRSArIGhzeW5jX2J5dGVzICsKPiAtCQlEU0lfSFNBX1BBQ0tFVF9FWFRS QV9TSVpFICsgRFNJX0hTRV9QQUNLRVRfU0laRSArCj4gLQkJaGJwX2J5dGVzICsgRFNJX0hCUF9Q QUNLRVRfRVhUUkFfU0laRSArCj4gLQkJaGFjdGl2ZV9ieXRlcyArIERTSV9IQUNUSVZFX1BBQ0tF VF9FWFRSQV9TSVpFICsKPiAtCQloZnBfYnl0ZXMgKyBEU0lfSEZQX1BBQ0tFVF9FWFRSQV9TSVpF Owo+IC0KPiAtCS8qCj4gLQkgKiBYWFg6IE5lZWQgdG8gYWNjdXJhdGVseSBjYWxjdWxhdGUgTFAg dG8gSFMgdHJhbnNpdGlvbiB0aW1lb3V0IGFuZCBhZGQKPiAtCSAqIGl0IHRvIGJ5dGVzX3Blcl9s aW5lL2J5dGVzX3Blcl9mcmFtZS4KPiAtCSAqLwo+IC0KPiAtCWlmIChlb3RwICYmIHZpZGVvX21v ZGVfZm9ybWF0ID09IFZJREVPX01PREVfQlVSU1QpCj4gLQkJYnl0ZXNfcGVyX2xpbmUgKz0gRFNJ X0VPVFBfUEFDS0VUX1NJWkU7Cj4gLQo+IC0JYnl0ZXNfcGVyX2ZyYW1lID0gdnN5bmMgKiBieXRl c19wZXJfbGluZSArIHZicCAqIGJ5dGVzX3Blcl9saW5lICsKPiAtCQl2YWN0aXZlICogYnl0ZXNf cGVyX2xpbmUgKyB2ZnAgKiBieXRlc19wZXJfbGluZTsKPiAtCj4gLQlpZiAoZW90cCAmJgo+IC0J ICAgICh2aWRlb19tb2RlX2Zvcm1hdCA9PSBWSURFT19NT0RFX05PTl9CVVJTVF9XSVRIX1NZTkNf UFVMU0UgfHwKPiAtCSAgICAgdmlkZW9fbW9kZV9mb3JtYXQgPT0gVklERU9fTU9ERV9OT05fQlVS U1RfV0lUSF9TWU5DX0VWRU5UUykpCj4gLQkJYnl0ZXNfcGVyX2ZyYW1lICs9IERTSV9FT1RQX1BB Q0tFVF9TSVpFOwo+IC0KPiAtCW51bV9mcmFtZXMgPSBkcm1fbW9kZV92cmVmcmVzaChtb2RlKTsK PiAtCWJ5dGVzX3Blcl94X2ZyYW1lcyA9IG51bV9mcmFtZXMgKiBieXRlc19wZXJfZnJhbWU7Cj4g LQo+IC0JYnl0ZXNfcGVyX3hfZnJhbWVzX3hfbGFuZXMgPSBieXRlc19wZXJfeF9mcmFtZXMgLyBs YW5lX2NvdW50Owo+IC0KPiAtCS8qIHRoZSBkc2kgY2xvY2sgaXMgZGl2aWRlZCBieSAyIGluIHRo ZSBoYXJkd2FyZSB0byBnZXQgZHNpIGRkciBjbG9jayAqLwo+IC0JZHNpX2JpdF9jbG9ja19oeiA9 IGJ5dGVzX3Blcl94X2ZyYW1lc194X2xhbmVzICogODsKPiAtCWRzaV9jbGsgPSBkc2lfYml0X2Ns b2NrX2h6IC8gMTAwMDsKPiAtCj4gLQlpZiAoZW90cCAmJiB2aWRlb19tb2RlX2Zvcm1hdCA9PSBW SURFT19NT0RFX0JVUlNUKQo+IC0JCWRzaV9jbGsgKj0gMjsKPiAtCj4gLQlyZXR1cm4gZHNpX2Ns azsKPiAtfQo+IC0KPiAtI2Vsc2UKPiArI2lmbmRlZiBEU0lfQ0xLX0ZST01fUlIKPiAgCj4gIC8q IEdldCBEU0kgY2xvY2sgZnJvbSBwaXhlbCBjbG9jayAqLwo+ICBzdGF0aWMgdTMyIGRzaV9jbGtf ZnJvbV9wY2xrKHUzMiBwY2xrLCBpbnQgcGl4ZWxfZm9ybWF0LCBpbnQgbGFuZV9jb3VudCkKPiAt LSAKPiAxLjcuMTAuNAo+CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hu b2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755155AbaLHK1k (ORCPT ); Mon, 8 Dec 2014 05:27:40 -0500 Received: from mga11.intel.com ([192.55.52.93]:56835 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754968AbaLHK1j (ORCPT ); Mon, 8 Dec 2014 05:27:39 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,537,1413270000"; d="scan'208";a="634353191" From: Jani Nikula To: Rickard Strandqvist , Daniel Vetter Cc: Rickard Strandqvist , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpu: drm: i915: intel_dsi_pll.c: Remove unused function In-Reply-To: <1417992176-20712-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1417992176-20712-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Notmuch/0.19~rc1+1~g08b4944 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Mon, 08 Dec 2014 12:27:15 +0200 Message-ID: <87a92yo2rg.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 08 Dec 2014, Rickard Strandqvist wrote: > Remove the function dsi_rr_formula() that is not used anywhere. Please don't. BR, Jani. > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > drivers/gpu/drm/i915/intel_dsi_pll.c | 83 +--------------------------------- > 1 file changed, 1 insertion(+), 82 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dsi_pll.c b/drivers/gpu/drm/i915/intel_dsi_pll.c > index fa7a6ca..20086e8 100644 > --- a/drivers/gpu/drm/i915/intel_dsi_pll.c > +++ b/drivers/gpu/drm/i915/intel_dsi_pll.c > @@ -50,88 +50,7 @@ static const u32 lfsr_converts[] = { > 71, 35 /* 91 - 92 */ > }; > > -#ifdef DSI_CLK_FROM_RR > - > -static u32 dsi_rr_formula(const struct drm_display_mode *mode, > - int pixel_format, int video_mode_format, > - int lane_count, bool eotp) > -{ > - u32 bpp; > - u32 hactive, vactive, hfp, hsync, hbp, vfp, vsync, vbp; > - u32 hsync_bytes, hbp_bytes, hactive_bytes, hfp_bytes; > - u32 bytes_per_line, bytes_per_frame; > - u32 num_frames; > - u32 bytes_per_x_frames, bytes_per_x_frames_x_lanes; > - u32 dsi_bit_clock_hz; > - u32 dsi_clk; > - > - switch (pixel_format) { > - default: > - case VID_MODE_FORMAT_RGB888: > - case VID_MODE_FORMAT_RGB666_LOOSE: > - bpp = 24; > - break; > - case VID_MODE_FORMAT_RGB666: > - bpp = 18; > - break; > - case VID_MODE_FORMAT_RGB565: > - bpp = 16; > - break; > - } > - > - hactive = mode->hdisplay; > - vactive = mode->vdisplay; > - hfp = mode->hsync_start - mode->hdisplay; > - hsync = mode->hsync_end - mode->hsync_start; > - hbp = mode->htotal - mode->hsync_end; > - > - vfp = mode->vsync_start - mode->vdisplay; > - vsync = mode->vsync_end - mode->vsync_start; > - vbp = mode->vtotal - mode->vsync_end; > - > - hsync_bytes = DIV_ROUND_UP(hsync * bpp, 8); > - hbp_bytes = DIV_ROUND_UP(hbp * bpp, 8); > - hactive_bytes = DIV_ROUND_UP(hactive * bpp, 8); > - hfp_bytes = DIV_ROUND_UP(hfp * bpp, 8); > - > - bytes_per_line = DSI_HSS_PACKET_SIZE + hsync_bytes + > - DSI_HSA_PACKET_EXTRA_SIZE + DSI_HSE_PACKET_SIZE + > - hbp_bytes + DSI_HBP_PACKET_EXTRA_SIZE + > - hactive_bytes + DSI_HACTIVE_PACKET_EXTRA_SIZE + > - hfp_bytes + DSI_HFP_PACKET_EXTRA_SIZE; > - > - /* > - * XXX: Need to accurately calculate LP to HS transition timeout and add > - * it to bytes_per_line/bytes_per_frame. > - */ > - > - if (eotp && video_mode_format == VIDEO_MODE_BURST) > - bytes_per_line += DSI_EOTP_PACKET_SIZE; > - > - bytes_per_frame = vsync * bytes_per_line + vbp * bytes_per_line + > - vactive * bytes_per_line + vfp * bytes_per_line; > - > - if (eotp && > - (video_mode_format == VIDEO_MODE_NON_BURST_WITH_SYNC_PULSE || > - video_mode_format == VIDEO_MODE_NON_BURST_WITH_SYNC_EVENTS)) > - bytes_per_frame += DSI_EOTP_PACKET_SIZE; > - > - num_frames = drm_mode_vrefresh(mode); > - bytes_per_x_frames = num_frames * bytes_per_frame; > - > - bytes_per_x_frames_x_lanes = bytes_per_x_frames / lane_count; > - > - /* the dsi clock is divided by 2 in the hardware to get dsi ddr clock */ > - dsi_bit_clock_hz = bytes_per_x_frames_x_lanes * 8; > - dsi_clk = dsi_bit_clock_hz / 1000; > - > - if (eotp && video_mode_format == VIDEO_MODE_BURST) > - dsi_clk *= 2; > - > - return dsi_clk; > -} > - > -#else > +#ifndef DSI_CLK_FROM_RR > > /* Get DSI clock from pixel clock */ > static u32 dsi_clk_from_pclk(u32 pclk, int pixel_format, int lane_count) > -- > 1.7.10.4 > -- Jani Nikula, Intel Open Source Technology Center