From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] fat: fix data past EOF resulting from fsx testsuite
Date: Wed, 12 Nov 2014 19:09:32 +0900 [thread overview]
Message-ID: <87a93w20ir.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <009a01cffe5f$ba714f50$2f53edf0$@samsung.com> (Namjae Jeon's message of "Wed, 12 Nov 2014 19:02:11 +0900")
Namjae Jeon <namjae.jeon@samsung.com> writes:
> When running FSX with direct I/O mode, fsx resulted in DATA past EOF issues.
>
> fsx ./file2 -Z -r 4096 -w 4096
> ...
> ..
> truncating to largest ever: 0x907c
> fallocating to largest ever: 0x11137
> truncating to largest ever: 0x2c6fe
> truncating to largest ever: 0x2cfdf
> fallocating to largest ever: 0x40000
> Mapped Read: non-zero data past EOF (0x18628) page offset 0x629 is 0x2a4e
> ...
> ..
>
> The reason being, it is doing a truncate down, but the zeroing does
> not happen on the last block boundary when offset is not aligned.
> Even though it calls truncate_setsize()->truncate_inode_pages()->
> truncate_inode_pages_range() and considers the partial zeroout but it
> retrieves the page using find_lock_page() - which only looks the page in
> the cache. So, zeroing out does not happen in case of direct IO.
>
> Make a truncate page based around block_truncate_page for FAT filesystem and
> invoke that helper to zerout in case the offset is not aligned with
> the blocksize.
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Thanks.
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
> ---
> fs/fat/fat.h | 1 +
> fs/fat/file.c | 3 +++
> fs/fat/inode.c | 12 ++++++++++++
> 3 files changed, 16 insertions(+)
>
> diff --git a/fs/fat/fat.h b/fs/fat/fat.h
> index eff027d..61801da 100644
> --- a/fs/fat/fat.h
> +++ b/fs/fat/fat.h
> @@ -374,6 +374,7 @@ extern int fat_file_fsync(struct file *file, loff_t start, loff_t end,
> int datasync);
>
> /* fat/inode.c */
> +extern int fat_block_truncate_page(struct inode *inode, loff_t from);
> extern void fat_attach(struct inode *inode, loff_t i_pos);
> extern void fat_detach(struct inode *inode);
> extern struct inode *fat_iget(struct super_block *sb, loff_t i_pos);
> diff --git a/fs/fat/file.c b/fs/fat/file.c
> index f2c73ae..757fc20 100644
> --- a/fs/fat/file.c
> +++ b/fs/fat/file.c
> @@ -523,6 +523,9 @@ int fat_setattr(struct dentry *dentry, struct iattr *attr)
> }
>
> if (attr->ia_valid & ATTR_SIZE) {
> + error = fat_block_truncate_page(inode, attr->ia_size);
> + if (error)
> + goto out;
> down_write(&MSDOS_I(inode)->truncate_lock);
> truncate_setsize(inode, attr->ia_size);
> fat_truncate_blocks(inode, attr->ia_size);
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index f362796..9bf44eb 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -339,6 +339,18 @@ static sector_t _fat_bmap(struct address_space *mapping, sector_t block)
> return blocknr;
> }
>
> +/*
> + * fat_block_truncate_page() zeroes out a mapping from file offset `from'
> + * up to the end of the block which corresponds to `from'.
> + * This is required during truncate to physically zeroout the tail end
> + * of that block so it doesn't yield old data if the file is later grown.
> + * Also, avoid causing failure from fsx for cases of "data past EOF"
> + */
> +int fat_block_truncate_page(struct inode *inode, loff_t from)
> +{
> + return block_truncate_page(inode->i_mapping, from, fat_get_block);
> +}
> +
> static const struct address_space_operations fat_aops = {
> .readpage = fat_readpage,
> .readpages = fat_readpages,
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2014-11-12 10:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 10:02 [PATCH v2] fat: fix data past EOF resulting from fsx testsuite Namjae Jeon
2014-11-12 10:09 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a93w20ir.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.