From mboxrd@z Thu Jan 1 00:00:00 1970 From: Namhyung Kim Subject: Re: [PATCH] perf top: Add a visual cue for toggle zeroing of samples Date: Tue, 07 Oct 2014 14:26:19 +0900 Message-ID: <87a958h2mc.fsf@sejong.aot.lge.com> References: <1412491774-2971-1-git-send-email-treeze.taeung@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from lgeamrelo04.lge.com ([156.147.1.127]:55155 "EHLO lgeamrelo04.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752430AbaJGF0V (ORCPT ); Tue, 7 Oct 2014 01:26:21 -0400 In-Reply-To: <1412491774-2971-1-git-send-email-treeze.taeung@gmail.com> (Taeung Song's message of "Sun, 5 Oct 2014 15:49:34 +0900") Sender: linux-perf-users-owner@vger.kernel.org List-ID: To: Taeung Song Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, jolsa@redhat.com, linux-perf-users@vger.kernel.org Hi Taeung, On Sun, 5 Oct 2014 15:49:34 +0900, Taeung Song wrote: > When 'perf top' is run, one can't easily find a difference > between -z option and normal output. > So I added a visual cue to know whether it is the zeroing or not. [SNIP] > +static int hists__browser_title(struct hists *hists, > + struct hist_browser_timer *hbt, > + char *bf, > + size_t size) You don't need to align arguments like this. > { > char unit; > int printed; > @@ -1256,6 +1268,14 @@ static int hists__browser_title(struct hists *hists, char *bf, size_t size) > if (dso) > printed += scnprintf(bf + printed, size - printed, > ", DSO: %s", dso->short_name); > + if (!is_report_browser(hbt)) { > + struct perf_top *top = hbt->arg; > + > + if (top->zero) > + printed += scnprintf(bf + printed, size - printed, > + ", [z]", ""); It seems the final empty string can go away. And personally I'd like to get rid of "," before "[z]" also. Otherwise looks good to me. Could you please take a look at the stdio output too? Thanks, Namhyung > + } > + > return printed; > } > > @@ -1267,12 +1287,6 @@ static inline void free_popup_options(char **options, int n) > zfree(&options[i]); > } > > -/* Check whether the browser is for 'top' or 'report' */ > -static inline bool is_report_browser(void *timer) > -{ > - return timer == NULL; > -} > - > /* > * Only runtime switching of perf data file will make "input_name" point > * to a malloced buffer. So add "is_input_name_malloced" flag to decide