From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36419)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XSKUn-0005pZ-W8
	for qemu-devel@nongnu.org; Fri, 12 Sep 2014 02:38:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XSKUi-0008DM-Sq
	for qemu-devel@nongnu.org; Fri, 12 Sep 2014 02:38:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:3420)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XSKUi-0008DE-LA
	for qemu-devel@nongnu.org; Fri, 12 Sep 2014 02:38:08 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1410336832-22160-1-git-send-email-armbru@redhat.com>
	<1410336832-22160-11-git-send-email-armbru@redhat.com>
	<20140911170604.GA9475@irqsave.net>
	<874mwe7yz7.fsf@blackfin.pond.sub.org>
	<20140911193359.GA7305@irqsave.net> <5411FAB3.9080409@redhat.com>
Date: Fri, 12 Sep 2014 08:38:03 +0200
In-Reply-To: <5411FAB3.9080409@redhat.com> (Eric Blake's message of "Thu, 11
	Sep 2014 13:40:35 -0600")
Message-ID: <87a9652vjo.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member
	bdrv, use blk_by_legacy_dinfo()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: =?utf-8?Q?Beno=C3=AEt?= Canet <benoit.canet@irqsave.net>, kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

Eric Blake <eblake@redhat.com> writes:

> On 09/11/2014 01:34 PM, Beno=C3=AEt Canet wrote:
>> The Thursday 11 Sep 2014 =C3=A0 21:12:44 (+0200), Markus Armbruster wrot=
e :
>>> Beno=C3=AEt Canet <benoit.canet@irqsave.net> writes:
>>>
>>>>> +                                   blk_bs(blk_by_legacy_dinfo(dinfo)=
));
>>>>
>>>> This seems to be a fairly common pattern: "blk_bs(blk_by_legacy_dinfo(=
))".
>>>> How about a helper function ?
>>>
>>> Yes, except the pattern is going to evaporate in patch 14 :)
>>=20
>> haha
>
> Still, worth mentioning this fact in the commit message, rather than
> making reviewers guess at it (that is, add a sentence something like:
> This commit mechanically introduces long lines via repetitive pattern
> replacement that will be shortened in a later patch

I can do that.