From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52093)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XOMSO-0004N5-3T
	for qemu-devel@nongnu.org; Mon, 01 Sep 2014 03:55:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XOMSJ-0007kI-9R
	for qemu-devel@nongnu.org; Mon, 01 Sep 2014 03:55:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13891)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XOMSJ-0007k2-3D
	for qemu-devel@nongnu.org; Mon, 01 Sep 2014 03:55:15 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <87oave58q3.fsf@blackfin.pond.sub.org>
	<20140821131237.GA22844@stefanha-thinkpad.redhat.com>
	<CAFEAcA9JmB9XTTjgLGXdwqEyO2ncfHFoMfwNAJivMMd2LFPf5w@mail.gmail.com>
	<20140828110556.GH26741@stefanha-thinkpad.redhat.com>
	<87r400eixv.fsf@blackfin.pond.sub.org> <5400DD19.700@redhat.com>
Date: Mon, 01 Sep 2014 09:55:07 +0200
In-Reply-To: <5400DD19.700@redhat.com> (Max Reitz's message of "Fri, 29 Aug
	2014 22:05:45 +0200")
Message-ID: <87a96jixlw.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] What tests should "make check-block" run?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Peter Maydell <peter.maydell@linaro.org>

Max Reitz <mreitz@redhat.com> writes:

> On 28.08.2014 17:24, Markus Armbruster wrote:
>> Stefan Hajnoczi <stefanha@gmail.com> writes:
>>
>>> On Thu, Aug 21, 2014 at 02:16:36PM +0100, Peter Maydell wrote:
>>>> On 21 August 2014 14:12, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>>>>> On Thu, Aug 21, 2014 at 02:27:00PM +0200, Markus Armbruster wrote:
>>>>>> Should we have a variant of "make check-block" for testing other
>>>>>> (format, protocol) combinations?
>>>>> I don't think variants are useful.  If you need control, use ./check.
>>>> That seems pretty undiscoverable to me. I know about 'make check',
>>>> and 'make check-help' tells me about 'make check-block', but how
>>>> do I find out about 'check' ? I just had to bounce through the makefile
>>>> and a wrapper script to even figure out which directory it lives in,
>>>> and there's no help text or usage comments in it...
>>> http://qemu-project.org/Documentation/QemuIoTests
>> I'm afraid this needs updating for Max's recent "iotests: Allow
>> out-of-tree run" series.  Max?
>
> Done. Thanks for notifying me.

Looks good, thank you!