From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBkWi-0007sG-Rh for qemu-devel@nongnu.org; Mon, 28 Jul 2014 08:59:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBkWb-0000Ly-Or for qemu-devel@nongnu.org; Mon, 28 Jul 2014 08:59:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBkWb-0000Lf-H7 for qemu-devel@nongnu.org; Mon, 28 Jul 2014 08:59:33 -0400 From: Juan Quintela In-Reply-To: (Peter Maydell's message of "Fri, 25 Jul 2014 17:00:35 +0100") References: <1406290560-13561-1-git-send-email-pbonzini@redhat.com> <53D26829.4080000@redhat.com> Date: Mon, 28 Jul 2014 14:59:26 +0200 Message-ID: <87a97twsep.fsf@troll.troll> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PULL for-2.1 0/3] Last minute patches Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Igor Mammedov Cc: Paolo Bonzini , QEMU Developers Peter Maydell wrote: > On 25 July 2014 15:22, Paolo Bonzini wrote: >> Since Igor hasn't sent his patches, and I'm leaving the office, I pushed >> this to >> >> git://github.com/bonzini/qemu.git tags/for-upstream-full >> >> I don't know about tests/acpi-test-data/pc. It makes sense that this >> patch should modify something there, but: >> >> * "make check" passes >> >> * the test warns even before patch 1, for both the DSDT (modified by the >> patch) and SSDT (which this series doesn't touch at all) >> >> * I cannot get it to pass, except by blindly copying the "actual" output >> on the "expected" files >> >> * mst is on vacation and Marcel is off on Fridays >> >> Based on my understanding of the problem, it is not possible to fix the >> bug without hacks like this one, and even reverting all patches in this >> area would be more risky. > > Hmm. I'm not really sure what the right thing is, so what > I'm planning to do is: > * just apply the qemu-char fix for now > * not tag -rc4 today > * see if things are clearer on Monday (I see Igor has now > sent out a patchset) > * tag -rc4 Mon or Tues > * slip the release date a few days (not a big deal, I think) I am reading both patch-sets. I preffer very much Paolo solution to Igor one. But I have to say that I don't understand PATCH 1 (neither before or after the change). Solution does what we should do, that is generate the size that destination is expecting, and no simply blindy accept packages that are smaller. The compatibility bits of PATCH2 look ok (that ones, I can kind of understand them). Igor? Later, Juan.