From: Rusty Russell <rusty@rustcorp.com.au>
To: Lucas De Marchi <lucas.de.marchi@gmail.com>,
"Matwey V. Kornilov" <matwey.kornilov@gmail.com>
Cc: Gustavo Sverzut Barbieri <barbieri@gmail.com>,
linux-modules <linux-modules@vger.kernel.org>
Subject: Re: [PATCH] Fix recursion loop in mod_count_all_dependencies()
Date: Mon, 05 May 2014 11:15:00 +0930 [thread overview]
Message-ID: <87a9axc82r.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20140502141357.GA24741@politreco>
Lucas De Marchi <lucas.de.marchi@gmail.com> writes:
> [ CC'ing Rusty ]
>
> Rusty, when facing module loops, shouldn't we let depmod fail? kmod and
> module-init-tools since always just warned about them, but it's really a
> bug in the module if they exist. See below.
Yes. Soft dependencies can loop, but hard dependencies should barf.
Note that in the case where two modules could satisfy a dependencies,
it may not be a real loop?
Cheers,
Rusty.
next prev parent reply other threads:[~2014-05-05 1:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 19:31 [PATCH] Fix recursion loop in mod_count_all_dependencies() matwey.kornilov
2014-04-25 3:46 ` Lucas De Marchi
2014-04-27 15:30 ` Gustavo Sverzut Barbieri
2014-04-27 19:44 ` Matwey V. Kornilov
2014-05-02 14:13 ` Lucas De Marchi
2014-05-02 14:29 ` Matwey V. Kornilov
2014-05-05 1:45 ` Rusty Russell [this message]
2014-05-05 4:29 ` Lucas De Marchi
2014-05-05 10:11 ` Rusty Russell
2014-05-05 10:16 ` Matwey V. Kornilov
2014-05-05 12:44 ` Lucas De Marchi
2014-05-05 12:37 ` Lucas De Marchi
[not found] ` <CAKi4VA+R6TBbgVv1yAjKi0cU=Q+X8zFDQQ0e3hNiQ5meDhsiEg@mail.gmail.com>
2014-04-27 20:04 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9axc82r.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=barbieri@gmail.com \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=matwey.kornilov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.