From: Markus Armbruster <armbru@redhat.com>
To: Hani Benhabiles <kroosec@gmail.com>
Cc: stefanha@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com,
pbonzini@redhat.com, imammedo@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH] qdev: Assign a default device ID when none is provided.
Date: Wed, 08 Jan 2014 08:36:06 +0100 [thread overview]
Message-ID: <87a9f7c4d5.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1389121639-17657-1-git-send-email-kroosec@gmail.com> (Hani Benhabiles's message of "Tue, 7 Jan 2014 20:07:19 +0100")
Hani Benhabiles <kroosec@gmail.com> writes:
> This would allow a user to be able to refer to the device when using commands
> like device_del.
>
> Signed-off-by: Hani Benhabiles <kroosec@gmail.com>
No.
Device IDs belong to the user. Any IDs the system picks automatically
can collide with the user's IDs.
Management applications assume that they can pick any ID they want.
Your patch can introduce ID collisions, and thus make existing
configurations fail.
If I remember correctly, a few legacy convenience options pick IDs for
historical reasons. If you use them, you need to be aware of the IDs
they pick. Management applications shouldn't use them.
We've discussed this a couple of times already, by the way.
next prev parent reply other threads:[~2014-01-08 7:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 19:07 [Qemu-devel] [PATCH] qdev: Assign a default device ID when none is provided Hani Benhabiles
2014-01-08 7:36 ` Markus Armbruster [this message]
2014-01-08 17:17 ` Hani Benhabiles
2014-01-08 17:34 ` Paolo Bonzini
2014-01-09 18:18 ` Hani Benhabiles
2014-01-09 18:33 ` Paolo Bonzini
2014-01-10 9:09 ` Markus Armbruster
2014-01-10 9:42 ` Andreas Färber
2014-01-10 11:54 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9f7c4d5.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=imammedo@redhat.com \
--cc=kroosec@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.