From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0ngZ-0006HY-6t for qemu-devel@nongnu.org; Wed, 08 Jan 2014 02:36:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0ngT-0006gl-89 for qemu-devel@nongnu.org; Wed, 08 Jan 2014 02:36:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0ngS-0006gf-Vx for qemu-devel@nongnu.org; Wed, 08 Jan 2014 02:36:13 -0500 From: Markus Armbruster References: <1389121639-17657-1-git-send-email-kroosec@gmail.com> Date: Wed, 08 Jan 2014 08:36:06 +0100 In-Reply-To: <1389121639-17657-1-git-send-email-kroosec@gmail.com> (Hani Benhabiles's message of "Tue, 7 Jan 2014 20:07:19 +0100") Message-ID: <87a9f7c4d5.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] qdev: Assign a default device ID when none is provided. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hani Benhabiles Cc: stefanha@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com, pbonzini@redhat.com, imammedo@redhat.com, afaerber@suse.de Hani Benhabiles writes: > This would allow a user to be able to refer to the device when using commands > like device_del. > > Signed-off-by: Hani Benhabiles No. Device IDs belong to the user. Any IDs the system picks automatically can collide with the user's IDs. Management applications assume that they can pick any ID they want. Your patch can introduce ID collisions, and thus make existing configurations fail. If I remember correctly, a few legacy convenience options pick IDs for historical reasons. If you use them, you need to be aware of the IDs they pick. Management applications shouldn't use them. We've discussed this a couple of times already, by the way.