Re: [PATCHSET 0/7] perf tools: A couple of TUI improvements (v2)

[Namhyung Kim <namhyung@kernel.org>]

Hi Ingo,

On Fri, 20 Dec 2013 09:13:57 +0100, Ingo Molnar wrote:
> * Namhyung Kim <namhyung@kernel.org> wrote:
> Looks pretty good now!
>
> I found four small inconsistencies:
>
>  - in 'perf top' the '?' help text states that there's an 'i' key, but
>    that key does nothing.

Yes, I can split the help text for perf top and perf report as some keys
only work for perf report already.

>
>  - filtering support would be useful in the 'log' window as well :-)

It's for the 'log' window.  Did you mean the 'header' window? :)

>
>  - in both 'perf top' and 'perf report' neither the 'i' nor the 'l'
>    window shows any help window, so one has to guess that '/' does the
>    filtering.

Okay, I'll add the help.

>
>  - the hotkeys in the help window used to be ordered alphabetically - 
>    they aren't anymore.

Will be fixed with the split.

>
> While testing 'perf top' I also found three new features which would 
> be very nice to have, in case you are interested in implementing them:

Hmm.. looks like features for the long-term plan.  Not sure I can work
on it soon.

>
>  - it would be nice to have a hotkey to start/stop data collection on
>    demand, and another hotkey to reset the data. SysProf has this 
>    feature, and it's a convenient workflow to have a separate 'data 
>    collection' period (possibly done without any screen refresh, so 
>    that data collection does not disturb the measured workload), and 
>    a quiet 'look at all the data that is not being changed' period. 
>    Especially with fast changing workloads the latter can be useful.

I'm not sure I understood correctly.  So do you want start/stop the
'record' part or 'report' part with hotkeys?

>
>  - it would be nice if 'perf report' had a 'view raw trace' window as 
>    well, with filtering. That would be roughly equivalent to the 'perf
>    report -D' output [but one line per trace entry, i.e. no hex dump
>    shown by default], all available within the TUI. With filtering
>    that would be a pretty good way to look at various details.

Do you want something like 'perf script'? :)

>
>  - it might also be useful if it was possible to save a perf.data from 
>    a 'perf top' session - and to start a 'perf top' session from a 
>    specific perf.data [and with data collection disabled]. I.e. allow 
>    intermediate modes between 'perf top', 'perf report' and 'perf 
>    record' profiling workflows, all in a single TUI.

Someday.. :)


Thanks,
Namhyung