From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58746)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1VnmXV-0000CM-Dq
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 04:45:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1VnmXQ-0000NM-E2
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 04:45:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:28760)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1VnmXQ-0000LP-6c
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 04:45:04 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <cover.1386049636.git.peter.crosthwaite@xilinx.com>
Date: Tue, 03 Dec 2013 10:44:57 +0100
In-Reply-To: <cover.1386049636.git.peter.crosthwaite@xilinx.com> (Peter
	Crosthwaite's message of "Mon, 2 Dec 2013 21:49:20 -0800")
Message-ID: <87a9ginu92.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [RFC PATCH v1 0/5] Add error_abort and associated
	cleanups
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: imammedo@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, afaerber@suse.de

Peter Crosthwaite <peter.crosthwaite@xilinx.com> writes:

> Following our discussion RE self asserting API calls, here is a spin of
> my proposal. This series obsoletes the need for _nofail variants for
> Error ** accepting APIs. Is also greately reduces the verbosity of calls
> sites that are currently asserting against errors.
>
> Patch 1 is the main event - addition of error_abort. The following
> patches then cleanup uses of _nofail and assert_no_error().
>
> To give it a smoke test, I introduce a (critical) bug into QOM:
[...]
>  32 files changed, 100 insertions(+), 143 deletions(-)

I like it.  Nice diffstat, too.

There are some _nofail functions left, but none of them can use
error_abort.

If anything assigns to error_abort, we're probably screwed.  No bright
idea how to prevent that at compile-time.